Skip to content

Reject overflowing Naomi LST ranges - #2521

Open
acts-1631 wants to merge 1 commit into
flyinghead:masterfrom
acts-1631:fix/naomi-lst-range-validation
Open

acts-1631 wants to merge 1 commit into
flyinghead:masterfrom
acts-1631:fix/naomi-lst-range-validation

Conversation

@acts-1631

Copy link
Copy Markdown
Contributor

A crafted Naomi LST entry can wrap the calculation used to determine the ROM allocation size:

romSize = std::max(romSize, addr + sz);

The loader later uses the original address and size when reading the corresponding payload:

u8 *romDest = romBase + fstart[i];
fp->read(romDest, 1, fsize[i]);

For example, address 0x100 and size 0xffffffff produce a 255-byte allocation, but the payload read begins one byte past that allocation. Opening such a game set can overwrite Flycast heap memory and crash or corrupt the process.

Calculate each range end using 64-bit arithmetic and reject entries that cannot fit within the 32-bit Naomi address space before allocating or reading ROM data.

A crafted LST entry can wrap its address and size calculation. This
allocates a small ROM buffer before the payload is read beyond it.

Calculate each range end with 64-bit arithmetic and reject entries that
cannot fit in the 32-bit Naomi address space.
Press5elect pushed a commit to Press5elect/PSFlycast that referenced this pull request Oct 7, 2026
…ast's open pull requests, release candidates in the updater, no Screenshot control

- Netplay: the checksum of a save state or of a CDI, GDI or CUE image is the
  file's, not its pointer's (flyinghead#2513).
- sh4: the FPSCR cause field is cleared when the guest writes FPSCR (flyinghead#2531).
- CHD: the track metadata's text fields are held to their buffers (flyinghead#2384).
- Input: absolute mouse motion rebased after relative input (flyinghead#2528); axis
  detection for triggers that report as buttons (flyinghead#2213).
- Checks of an ISO9660 directory record, RZIP chunk sizes, DNS answers,
  GGPO input packets and card events, and a Naomi LST's ranges (flyinghead#2414,
  flyinghead#2415, flyinghead#2416, flyinghead#2519, flyinghead#2520, flyinghead#2521).
- The updater ranks v1.1.0-rc1 under v1.1.0, and a release's build is not
  offered candidates.
- The quick menu's Screenshot row and control are gone: the console's
  Create button takes screenshots.
- Built with PS5_Vulkan 5b5e4fc, the payload SDK fork at b5efad5 and
  libsmb2 7e4ff97.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant