Skip to content

input: rebase absolute mouse motion after relative input - #2528

Merged
flyinghead merged 1 commit into
flyinghead:masterfrom
richstokes:codex/macos-mouse-sync
Oct 7, 2026
Merged

flyinghead merged 1 commit into
flyinghead:masterfrom
richstokes:codex/macos-mouse-sync

Conversation

@richstokes

Copy link
Copy Markdown
Contributor

Returning from relative mouse input to absolute input can replay movement that the guest already consumed. For example, an absolute position of (100, 100), followed by captured movement of (100, 40), leaves the previous absolute position unchanged. The next absolute sample at (200, 140) then adds another (100, 40) to the guest mouse deltas. SDL mouse capture uses this sequence; captured touch input also switches back to absolute coordinates on finger release.

Invalidate that port's absolute-motion baseline when receiving relative input. The first subsequent absolute sample establishes a fresh baseline, and later samples produce normal deltas. Pending relative motion, fractional remainders, wheel motion, other ports, and the absolute coordinates used by lightguns are preserved. The first absolute sample intentionally contributes no relative movement because its displacement from the old coordinate space is unknown.

Validation:

  • Added six mouse tests. With the unmodified production mouse object, the two control tests pass and all four transition regressions fail. With the patch, all six pass.
  • Built and ad-hoc signed the macOS arm64 application with bundled SDL. Both upstream and patched builds boot DreamTOS to its desktop and complete its boot self-tests.
  • Ran the broader local non-HTTP suite: 139 of 142 tests pass. The three failures (AicaArmTest.LogicOpsTest, SDLControllerMappingTest.split_axis, and SDLControllerMappingTest.reverse_axis) and a teardown mutex exception also reproduce with the unmodified mouse object. The local macOS test runner uses GTest's main instead of the Cocoa application entry point; those build-only adjustments are not included here.

This fixes stale-baseline jumps, not permanent host/guest cursor alignment: Dreamcast mice report relative movement, and guest sensitivity or screen-edge clipping can independently change the guest position. Physical macOS capture/release testing remains unverified; desktop automation did not reliably deliver SDL input, so the before/after claim above is based on the production-code regression tests.

@flyinghead
flyinghead merged commit b4c38d6 into flyinghead:master Oct 7, 2026
19 checks passed
Press5elect pushed a commit to Press5elect/PSFlycast that referenced this pull request Oct 7, 2026
…ast's open pull requests, release candidates in the updater, no Screenshot control

- Netplay: the checksum of a save state or of a CDI, GDI or CUE image is the
  file's, not its pointer's (flyinghead#2513).
- sh4: the FPSCR cause field is cleared when the guest writes FPSCR (flyinghead#2531).
- CHD: the track metadata's text fields are held to their buffers (flyinghead#2384).
- Input: absolute mouse motion rebased after relative input (flyinghead#2528); axis
  detection for triggers that report as buttons (flyinghead#2213).
- Checks of an ISO9660 directory record, RZIP chunk sizes, DNS answers,
  GGPO input packets and card events, and a Naomi LST's ranges (flyinghead#2414,
  flyinghead#2415, flyinghead#2416, flyinghead#2519, flyinghead#2520, flyinghead#2521).
- The updater ranks v1.1.0-rc1 under v1.1.0, and a release's build is not
  offered candidates.
- The quick menu's Screenshot row and control are gone: the console's
  Create button takes screenshots.
- Built with PS5_Vulkan 5b5e4fc, the payload SDK fork at b5efad5 and
  libsmb2 7e4ff97.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants