Repository navigation
build: pass /utf-8 to tinygettext so non-UTF-8 locales can build - #2532
Merged
flyinghead merged 1 commit intoOct 7, 2026
Merged
Conversation
MSVC decodes source files that have no BOM using the active code page. On a
Windows install whose system locale is not UTF-8 (Japanese, Korean, ...) the
non-ASCII literals in core/deps/tinygettext/src/language.cpp -- the native
language names such as "Espanol" or "Azerbaycanca" -- are mis-decoded and the
build fails:
language.cpp(59,52): error C2001: newline in constant
language.cpp(59,52): error C2064: term does not evaluate to a function
taking 1 arguments
The main target already gets /utf-8 (CMakeLists.txt:294); this dependency was
missed. CI runs on an English locale, which is why it has gone unnoticed.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
badatbit
force-pushed
the
fix/msvc-utf8-source-charset
branch
from
October 5, 2026 04:16
e87daba to
10df27f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSVC decodes source files that have no BOM using the active code page. On a Windows install whose system locale is not UTF-8 (Japanese, Korean, ...), the non-ASCII literals in
core/deps/tinygettext/src/language.cpp(the native language names) are mis-decoded and the build fails:The main target already gets
/utf-8; the tinygettext dependency was missed. This adds/utf-8to that target only, underif(MSVC), so GCC/Clang builds are unaffected. CI runners use an English locale, which is why it hasn't shown up there.Tested: MSVC (Visual Studio 2026 Build Tools, x64) on a Korean-locale Windows 11 fails without the change and builds with it.
🤖 Generated with Claude Code