Skip to content

feat(core): add scheduler admission v0 boundary#356

Open
flyingrobots wants to merge 2 commits into
mainfrom
stack/scheduler-admission-v0-boundary
Open

feat(core): add scheduler admission v0 boundary#356
flyingrobots wants to merge 2 commits into
mainfrom
stack/scheduler-admission-v0-boundary

Conversation

@flyingrobots
Copy link
Copy Markdown
Owner

Summary

  • add Echo-owned SchedulerAdmission v0 fixture recording keyed by registered artifact handle
  • publish idempotent SchedulerAdmissionRecorded graph facts and reject unknown handles without publishing facts
  • advance the admission ladder from SchedulerAdmissionUnavailable to SchedulerWorkUnavailable without scheduler work, handler dispatch, or execution
  • update the ladder checkpoint docs and changelog

Validation

  • RED: cargo test -p warp-core --test optic_invocation_admission_tests resolved_scheduler_admission_advances_to_scheduler_work_unavailable (failed before implementation on missing scheduler boundary)
  • cargo test -p warp-core --test optic_invocation_admission_tests
  • cargo test -p warp-core --test causal_fact_publication_tests
  • cargo test -p warp-core --test optic_artifact_registry_tests
  • cargo check
  • pnpm exec markdownlint-cli2 CHANGELOG.md docs/design/optic-admission-ladder-checkpoint.md docs/design/budget-and-runtime-support-optic-admission.md
  • git diff --check
  • cargo test -p warp-core
  • pre-push full local gate: fmt, guards, clippy-core, tests-warp-core, rustdoc

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 19, 2026

Warning

Rate limit exceeded

@flyingrobots has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 38 minutes and 12 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: bd6809ee-85e6-405b-b275-aae3f936f34a

📥 Commits

Reviewing files that changed from the base of the PR and between 57de763 and d266303.

📒 Files selected for processing (7)
  • CHANGELOG.md
  • crates/warp-core/src/causal_facts.rs
  • crates/warp-core/src/optic_artifact.rs
  • crates/warp-core/tests/causal_fact_publication_tests.rs
  • crates/warp-core/tests/optic_invocation_admission_tests.rs
  • docs/design/budget-and-runtime-support-optic-admission.md
  • docs/design/optic-admission-ladder-checkpoint.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch stack/scheduler-admission-v0-boundary

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant