Skip to content

Merge with upstream#5

Merged
itsrafsanjani merged 5 commits into
masterfrom
merge_with_upstream
May 14, 2026
Merged

Merge with upstream#5
itsrafsanjani merged 5 commits into
masterfrom
merge_with_upstream

Conversation

@ma-04
Copy link
Copy Markdown
Member

@ma-04 ma-04 commented May 12, 2026

Summary by CodeRabbit

  • New Features

    • Added Entrypoint parameter for job runs, enabling users to override the default container entrypoint for greater execution flexibility.
  • Documentation

    • Added comprehensive documentation for the new Entrypoint parameter with usage examples and default behavior specifications.
  • Chores

    • Updated CI pipeline to include Renovate-created branches in automated testing.
    • Updated Go toolchain and project dependencies.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 12, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9396ca06-c7ef-4b83-9882-7fdb44d0b3dd

📥 Commits

Reviewing files that changed from the base of the PR and between 34bc51d and 798f2cd.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (5)
  • .github/workflows/test.yml
  • core/runjob.go
  • core/runjob_test.go
  • docs/jobs.md
  • go.mod

Walkthrough

This PR adds optional Entrypoint configuration to override container default entrypoints in job runs, complete with implementation, comprehensive table-driven test coverage, and user documentation. Infrastructure updates add CI support for Renovate branches and bump Go and build tool versions.

Changes

Entrypoint Override Support

Layer / File(s) Summary
Entrypoint contract and implementation
core/runjob.go
RunJob struct adds an Entrypoint *string field. buildContainer() conditionally applies the configured entrypoint by parsing it via args.GetArgs when the field is non-nil.
Entrypoint test coverage
core/runjob_test.go
TestRun refactored into table-driven test covering three entrypoint scenarios (nil, "/bin/bash -c", ""). Container assertions including Config.Entrypoint validation now run per test case.
User documentation
docs/jobs.md
Job-run parameters section documents the new Entrypoint field with description, example value, and default behavior.

Infrastructure Updates

Layer / File(s) Summary
CI and dependency updates
.github/workflows/test.yml, go.mod
Workflow test trigger adds renovate/** branch pattern. Go toolchain upgraded from go1.26.1 to go1.26.2, and github.com/magefile/mage dependency bumped from v1.16.1 to v1.17.1.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 A pointer to bash, a path through the flow,
Table-driven tests let us verify and know,
Entrypoints now dance where the containers run,
Docs tell the tale—our config's so fun! 🎉

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The PR title 'Merge with upstream' is vague and generic; it doesn't describe the actual changes (entrypoint support, renovate CI, Go dependencies) being introduced in this pull request. Use a more descriptive title that reflects the primary changes, such as 'Add entrypoint support to RunJob' or 'Support custom container entrypoint configuration'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch merge_with_upstream

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ma-04 ma-04 mentioned this pull request May 12, 2026
@itsrafsanjani itsrafsanjani merged commit 30baebd into master May 14, 2026
6 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request May 14, 2026
@ma-04 ma-04 deleted the merge_with_upstream branch May 14, 2026 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants