Skip to content

⚡ Bolt: Hoist polyphonic audio functions to reduce closure allocations#810

Draft
ford442 wants to merge 1 commit into
mainfrom
perf/hoist-triggerVoice-1823444082875990758
Draft

⚡ Bolt: Hoist polyphonic audio functions to reduce closure allocations#810
ford442 wants to merge 1 commit into
mainfrom
perf/hoist-triggerVoice-1823444082875990758

Conversation

@ford442

@ford442 ford442 commented Jun 26, 2026

Copy link
Copy Markdown
Owner

This PR optimizes the real-time audio polyphony trigger path in useAudioEngine.ts by hoisting triggerVoice and runVoices out of the notes.forEach loop. This avoids redundant function recreation and closure allocations per note during chords or polyphonic granular re-triggering, minimizing GC pressure and CPU overhead.

Impact

  • Reduces memory allocations per polyphonic note.
  • Reduces redundant derivations (e.g. pPitchAttack) evaluated during chords.

Measurement

Run pnpm test src/__tests__/useAudioEngine.perf.test.tsx to verify the execution of the hot-path triggers are correct and green.


PR created automatically by Jules for task 1823444082875990758 started by @ford442

…ioEngine.ts

- Removes redundant parameters calculation from inner loop
- Further reduces work in polyphonic audio hot path
- Complements previous noteToMidi hoisting
- All relevant tests green (WASM failures are environmental)

Co-authored-by: ford442 <9397845+ford442@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a693e5c6-4e22-4573-97aa-107513bcb402

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch perf/hoist-triggerVoice-1823444082875990758

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant