⚡ Bolt: Hoist polyphonic audio functions to reduce closure allocations#810
⚡ Bolt: Hoist polyphonic audio functions to reduce closure allocations#810ford442 wants to merge 1 commit into
Conversation
…ioEngine.ts - Removes redundant parameters calculation from inner loop - Further reduces work in polyphonic audio hot path - Complements previous noteToMidi hoisting - All relevant tests green (WASM failures are environmental) Co-authored-by: ford442 <9397845+ford442@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This PR optimizes the real-time audio polyphony trigger path in
useAudioEngine.tsby hoistingtriggerVoiceandrunVoicesout of thenotes.forEachloop. This avoids redundant function recreation and closure allocations per note during chords or polyphonic granular re-triggering, minimizing GC pressure and CPU overhead.Impact
pPitchAttack) evaluated during chords.Measurement
Run
pnpm test src/__tests__/useAudioEngine.perf.test.tsxto verify the execution of the hot-path triggers are correct and green.PR created automatically by Jules for task 1823444082875990758 started by @ford442