🎨 Palette: Improve button accessibility and semantic types#827
Conversation
Added explicit `type="button"` attributes to non-submit buttons to prevent accidental form submissions. Added descriptive `aria-label`s to unstyled/icon-only buttons across multiple components to improve screen reader accessibility. Fixed TS17001 duplicate attribute errors introduced during mass edits. Co-authored-by: ford442 <9397845+ford442@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reached
Next review available in: 4 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (15)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Added explicit `type="button"` attributes to non-submit buttons to prevent accidental form submissions. Added descriptive `aria-label`s to unstyled/icon-only buttons across multiple components to improve screen reader accessibility. Fixed TS17001 duplicate attribute errors introduced during mass edits. Co-authored-by: ford442 <9397845+ford442@users.noreply.github.com>
Added explicit `type="button"` attributes to non-submit buttons to prevent accidental form submissions. Added descriptive `aria-label`s to unstyled/icon-only buttons across multiple components to improve screen reader accessibility. Fixed TS17001 duplicate attribute errors introduced during mass edits. Co-authored-by: ford442 <9397845+ford442@users.noreply.github.com>
Reverted to previous commit to clear up TS17001 duplicate attributes, re-added `type="button"` and `aria-label` tags without duplicating, fixed ContextMenuNode and NoteSelector tremolo definitions. Co-authored-by: ford442 <9397845+ford442@users.noreply.github.com>
Resolve conflicts by keeping main's component versions since PR #827 already landed the type="button" accessibility fixes on main. Co-authored-by: Cursor <cursoragent@cursor.com>
Added explicit
type="button"attributes to non-submit buttons to prevent accidental form submissions. Added descriptivearia-labels to unstyled/icon-only buttons across multiple components to improve screen reader accessibility. Fixed TS17001 duplicate attribute errors introduced during mass edits.PR created automatically by Jules for task 7851228179113763862 started by @ford442