perf(forge): avoid unnecessary gas_snapshots clones#13969
Merged
mablr merged 5 commits intofoundry-rs:masterfrom Apr 30, 2026
Merged
perf(forge): avoid unnecessary gas_snapshots clones#13969mablr merged 5 commits intofoundry-rs:masterfrom
mablr merged 5 commits intofoundry-rs:masterfrom
Conversation
ArshLabs
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
Contributor
Author
|
bumping this, let me know if any changes are needed. |
zerosnacks
previously approved these changes
Apr 7, 2026
zerosnacks
changed the title
figtracer
previously approved these changes
Apr 23, 2026
mablr
dismissed stale reviews from figtracer, zerosnacks, and themself
via
c87e77f
mablr
approved these changes
Apr 24, 2026
DaniPopes
changed the title
Contributor
Author
|
@zerosnacks @mablr anything else to update from my end? |
mablr
reviewed
Apr 30, 2026
Collaborator
mablr
left a comment
mablr
left a comment
There was a problem hiding this comment.
lgtm, pending another approval.
stevencartavia
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
run_tests_inner() iterates
gas_snapshots(aBTreeMap<String, BTreeMap<String, String>>) twice, once for snapshot checking and once for emitting, using.clone().into_iter()each time. The map is accumulated across the per-suite loop and must survive each iteration, so ownership can't be taken. Neither path needs it.Solution
Switches both to
.iter(), dropping two unnecessary deep copies per test contract.PR Checklist