fix(config): report cache cleanup deletion failures#14358
Open
solanaXpeter wants to merge 1 commit intofoundry-rs:masterfrom
Open
fix(config): report cache cleanup deletion failures#14358solanaXpeter wants to merge 1 commit intofoundry-rs:masterfrom
solanaXpeter wants to merge 1 commit intofoundry-rs:masterfrom
Conversation
solanaXpeter
requested review from
0xrusowsky,
DaniPopes,
figtracer,
grandizzy,
mablr,
mattsse,
onbjerg,
stevencartavia and
zerosnacks
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Cache cleanup paths currently ignore all deletion errors.
That keeps missing paths best-effort, but it also hides permission and path-type failures while leaving stale cache state behind.
Solution
Ignore only
io::ErrorKind::NotFoundfor cache cleanup removals and return all other deletion errors with path context fromcleanupand theclean_foundry_*helpers.Add focused unit tests for missing-path and wrong-path-type cases.
PR Checklist