Skip to content

recognize uname -m returning arm64 (as it currently does on m1 mac) - #5

Open
scgilardi wants to merge 1 commit into
fredZen:masterfrom
scgilardi:recognize-arm64-for-arch
Open

scgilardi wants to merge 1 commit into
fredZen:masterfrom
scgilardi:recognize-arm64-for-arch

Conversation

@scgilardi

@scgilardi scgilardi commented Sep 30, 2022

Copy link
Copy Markdown

With this change, babashka installs successfully on my m1 mac. Before the change it complains about unbound var "arch". I think this supersedes Pull request #4 and resolves issue #3 .

  • the current version of apple command line tools (see below) on m1 mac returns "arm64" from uname -m

  • update so we recognize that and download the apple silicon build from babashka releases

  • also, on a failure to recognize uname -m output, make it clear which package (asdf-babashka) is having the problem.

  • ➜ lib git:(master) ✗ pkgutil -pkg-info=com.apple.pkg.CLTools_Executables
    package-id: com.apple.pkg.CLTools_Executables version: 14.0.0.0.1.1661618636 [...]

- the current version of apple command line tools (see below) on m1 mac
  returns "arm64" from `uname -m`
- update so we recognize that and download the apple silicon build from
  babashka releases
- also, on a failure to recognize `uname -m` output, make it clear which
  package (asdf-babashka) is having the problem.

- ➜  lib git:(master) ✗ pkgutil -pkg-info=com.apple.pkg.CLTools_Executables
  package-id: com.apple.pkg.CLTools_Executables
  version: 14.0.0.0.1.1661618636
  [...]
@scgilardi

Copy link
Copy Markdown
Author

I'm now thinking my mention of the command line tools and their version is irrelevant. uname is almost certainly part of the OS proper. That version is 12.6 .

@fredZen

fredZen commented Sep 30, 2022 via email

Copy link
Copy Markdown
Owner

@pvinis

pvinis commented Dec 1, 2022

Copy link
Copy Markdown

👀

@borkdude

borkdude commented Jan 6, 2023

Copy link
Copy Markdown

@fredZen Any chance you could merge this? Babashka on m1 currently doesn't work properly with this asdf plugin.

@pesterhazy

Copy link
Copy Markdown

Like @borkdude I'd love to see this land in master. Happy to help out with maintenance duties if time is of short supply

@borkdude

Copy link
Copy Markdown

This PR was merged over here in this fork:

asdf plugin add babashka https://github.com/mkarp/asdf-babashka.git

@pesterhazy

Copy link
Copy Markdown

Use this fork over @mkarp's. We're using babashka heavily at Pitch and are happy to help out with maintaining the fork while upstream is not responsive https://github.com/pitch-io/asdf-babashka

@acidghost

Copy link
Copy Markdown

@fredZen @borkdude @pesterhazy @mkarp @pitch-io
I'm trying to have this plugin replaced by the pitch.io fork (see asdf-vm/asdf-plugins#784).

Unfortunately the fork has two problems: does not accept issues and does not implement CI.

The first is needed for transparency and good OSS (I would not have to write here and ping people if I could open an issue there).

The latter is required to instill a bit of trust of recommended asdf plugins actually working.

@pesterhazy

pesterhazy commented Mar 30, 2023 via email

Copy link
Copy Markdown

@acidghost

Copy link
Copy Markdown

@pesterhazy Gentle reminder :)

@pesterhazy

Copy link
Copy Markdown

@acidghost thanks for the ping

Issues enabled, working on Github Actions now pitch-io#1

@pesterhazy

Copy link
Copy Markdown

@acidghost I've enabled Github Actions as well now

Let me know if there's anything else we should do to get this fork ready for asdf-plugins

@acidghost

Copy link
Copy Markdown

@pesterhazy Apparently not, the changes have been merged (https://github.com/asdf-vm/asdf-plugins#plugin-list).

@pesterhazy

Copy link
Copy Markdown

Excellent, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants