Patch away kernel module check in freebsd-update#133
Open
grembo wants to merge 1 commit into
Open
Conversation
This is a hack to avoid the slow and annoying check of installed kernel modules, which actually runs on the host system and has no value whatsoever when updating jails. There should be something done about this in freebsd-update at some point.
Contributor
Author
|
Example output from my machine, it's not helpful and takes a long time (at least if the connection is slow):
|
arrowd
approved these changes
Jul 3, 2026
arrowd
left a comment
arrowd
left a comment
Contributor
There was a problem hiding this comment.
The proper fix is to make upgrade_check_kmod_ports() to take the -b option into account.
For a temporary measure the change looks OK to me. Note that unrelated style fixes makes it harder to review. I usually try to put non-functional changes into a separate commit for that reason.
Contributor
Author
And probably
I agree, it was just so few that I didn't back them out this time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a hack to avoid the slow and annoying check of installed kernel modules, which actually runs on the host system and has no value whatsoever when updating jails.
There should be something done about this in freebsd-update at some point.
Pacified flake8 on the modified files while there.
Make sure to follow and check these boxes before submitting a PR! Thank you.