Conversation
Contributor
|
Please submit this ticket under Issues describing this feature, then link this PR to it. |
Author
|
I added an issue! #7761 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This pull request addresses an issue in FullCalendar when handling iCalendar feeds. According to the official FullCalendar documentation, non-standard fields in event objects are moved into the
extendedPropshash during event parsing, allowing developers to add custom properties to events. However, in the current implementation for iCalendar feeds, it was not possible to include additional custom properties inextendedProps. Only specific values such aslocation,organizer, anddescriptionwere allowed, preventing developers from adding their own custom properties.To resolve this, I modified the
expandICalEventsandbuildNonDatePropsfunctions so that anyextendedPropspassed as part of the event source configuration are merged into the event object. This allows custom properties provided viaextendedPropsto be included in the event object for iCalendar feeds.Summary of Changes
expandICalEventsto pass theextendedPropsreceived from the event source configuration when building each event object.buildNonDatePropsto ensure that theextendedPropsare properly merged with the iCalendar event’slocation,organizer, anddescriptionfields, so custom properties can be added to the event.This fix ensures that developers can now include their own custom properties in
extendedPropswhen working with iCalendar feeds, as described in the FullCalendar documentation.#7761