Make backspace after swipe word deletion configurable - #2275
Open
drdanz wants to merge 1 commit into
Open
Conversation
|
Please sign our contributor license agreement at https://cla.futo.tech |
|
Please sign our contributor license agreement at https://cla.futo.tech |
Zvonimir-FUTO
added
Enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the current behaviour, when backspace is pressed after a swipe, the whole word just inserted by the swipe is deleted.
For languages like Italian, this makes the keyboard almost unusable, since the last 1 to 3 letters change completely the meaning of a word, and of a sentence if not corrected. Confirming the word and hitting backspace twice for every word adds a lot of extra typing (not considering that I'm used to have this feature from Ms SwiftKey, and I've been deleting a lot of words by mistake since I started using Futo Keyboard).
This PR adds an option to disable the word deletion when backspace is hit after a swipe, and instead delete the last character and exit batch mode.
Note: This feature was requested in #1368, that was closed as not planned. I'm proposing this PR anyway, since this is, in my opinion, a big usability problem.
AI Disclosure: I have no familiarity with the code base and a limited experience with java, therefore I used AI to navigate and understand the code, figure out how to exit batch mode after the first backspace, review the patch and to write the unit tests (I personally reviewed these afterwards).