This repository was archived by the owner on Jan 25, 2023. It is now read-only.
Add ERROR value (issue #254) #259
Open
sdelatorrep wants to merge 4 commits into
Open
Conversation
jrambla
previously approved these changes
Jan 17, 2019
teemukataja
suggested changes
Jan 18, 2019
Contributor
teemukataja
left a comment
teemukataja
left a comment
There was a problem hiding this comment.
ALL, HIT and MISS values are inclusive, but the current ERROR wording implies exclusive behaviour - hence the suggestions.
However, I feel that this ERROR value is not necessary:
In case of an error in the request to a Beacon, or in the response from a Beacon, an error object is always returned along with exists: null. If an error occurred, then the datasetAlleleResponses object will be empty, as the Beacon was unable to resolve the request.
What this means is that includeDatasetResponses=ERROR is not needed.
Co-Authored-By: sdelatorrep <sabela.delatorrep@gmail.com>
Co-Authored-By: sdelatorrep <sabela.delatorrep@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.