Widen declaration for many matrix related functions #6095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilfwilson
approved these changes
Sep 5, 2025
Member
wilfwilson
left a comment
wilfwilson
left a comment
There was a problem hiding this comment.
Seems fine to me.
The diffs in the manual examples are harmless, as far as I can tell (the relevant groups are equal, they're just given by different generating sets).
Member
|
There's still one pesky harmless failing manual example 🙁 |
fingolfin
force-pushed
the
mh/widen-matrix-to-matrixobj
branch
from
e1105b7 to
d8b8c29
Compare
Also remove some now redundant methods.
Before:
gap> m:=RandomMat(256, 256, GF(1000000007));;
gap> mat:=Matrix(IsZmodnZMatrixRep, GF(1000000007), m);;
gap> RankMat(mat)=256; time;
true
170
gap> DeterminantMat(mat); time;
ZmodpZObj( 873487643, 1000000007 )
23982
After:
gap> m:=RandomMat(256, 256, GF(1000000007));;
gap> mat:=Matrix(IsZmodnZMatrixRep, GF(1000000007), m);;
gap> RankMat(mat)=256; time;
true
161
gap> DeterminantMat(mat); time;
ZmodpZObj( 873487643, 1000000007 )
1949
fingolfin
force-pushed
the
mh/widen-matrix-to-matrixobj
branch
from
d8b8c29 to
ae66eef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove some now redundant methods.
Before:
After:
As discussed on #6088