Skip to content

Conversation

@Leon-hk
Copy link

@Leon-hk Leon-hk commented Nov 13, 2025

What this PR does / why we need it:

Usage: (updated)

usage: gl-build [-h] [--output-dir OUTPUT_DIR] [--package-dir PACKAGE_DIR]
                {export-python-libs}

Special notes for your reviewer:

Feel free to criticise a lot, this is my first contribution to python-gardenlinux-lib. I also do not know which version to put into the docstrings

Copy link
Contributor

@NotTheEvilOne NotTheEvilOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the proper package name would be gardenlinux.build. We could add a __main__.py there that currently accepts one command line argument export-python-libs.

The command line script could be named gl-build.

@NotTheEvilOne
Copy link
Contributor

Looks good so far now. Could you please add some unit tests to check for the command line tool to actually produce the result you are expecting?

@Leon-hk
Copy link
Author

Leon-hk commented Nov 25, 2025

I've added a test for the exporter. A test for the entire setup is also contained in #3914. I think testing the main program explicitly is not necessary.

Copy link
Contributor

@NotTheEvilOne NotTheEvilOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change, otherwise looks good for me :)

@Leon-hk
Copy link
Author

Leon-hk commented Nov 26, 2025

Thank you :) Have you seen Florians message regarding this on Slack?

@NotTheEvilOne
Copy link
Contributor

Thank you :) Have you seen Florians message regarding this on Slack?

Unfortunately I've no access to Slack at the moment.

@Leon-hk
Copy link
Author

Leon-hk commented Nov 26, 2025

I've created a Teams group, hope you can access it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants