-
Notifications
You must be signed in to change notification settings - Fork 1
feat: Port exportLibs.py script to python-gardenlinux-lib
#253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the proper package name would be gardenlinux.build. We could add a __main__.py there that currently accepts one command line argument export-python-libs.
The command line script could be named gl-build.
|
Looks good so far now. Could you please add some unit tests to check for the command line tool to actually produce the result you are expecting? |
|
I've added a test for the exporter. A test for the entire setup is also contained in #3914. I think testing the main program explicitly is not necessary. |
NotTheEvilOne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small change, otherwise looks good for me :)
|
Thank you :) Have you seen Florians message regarding this on Slack? |
Unfortunately I've no access to Slack at the moment. |
|
I've created a Teams group, hope you can access it |
What this PR does / why we need it:
exportLibs.pyscript from feat: add container-python-dev for multi-stage builds gardenlinux#3695 in python-gardenlinux-libUsage: (updated)
Special notes for your reviewer:
Feel free to criticise a lot, this is my first contribution to python-gardenlinux-lib. I also do not know which version to put into the docstrings