fix(ship): tighten Plan Completion gate #1302
Open
vaskockorovski wants to merge 1 commit intogarrytan:mainfrom
Open
fix(ship): tighten Plan Completion gate #1302vaskockorovski wants to merge 1 commit intogarrytan:mainfrom
vaskockorovski wants to merge 1 commit intogarrytan:mainfrom
Conversation
VAS-446 shipped with a PLAN.md acceptance criterion (domain-hq has /docs/dashboard.md) silently skipped. /ship's Plan Completion subagent existed at ship time (added in v1.4.1.0) but the gate let the failure through. Four structural fixes: 1. Path concreteness rule: items naming a concrete filesystem path MUST be classified DONE/NOT DONE via [ -f <path> ], never UNVERIFIABLE. 2. Validator detection: CONTENT-SHAPE items scan target repo's package.json for validate-* scripts and run them before falling back to UNVERIFIABLE. 3. Per-item UNVERIFIABLE confirmation: replaces blanket "I've checked each one" with per-item Y/N/D loop. The blanket-confirm path is the exact failure VAS-449 surfaced. 4. Subagent fail-closed: if Plan Completion subagent + inline fallback both fail, surface explicit AskUserQuestion instead of silent pass. Replaces the prior "Never block /ship on subagent failure" fail-open. Locked in by test/ship-plan-completion-invariants.test.ts (5 assertions, no LLM dependency, ~60ms). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A real failure mode surfaced during a recent autoplan sprint: a PLAN.md acceptance criterion (a CROSS-REPO file deliverable) shipped silently. The Plan Completion subagent existed (added in v1.4.1.0) but the gate let it through.
Four structural fixes to
ship/SKILL.mdStep 8:[ -f <path> ], never UNVERIFIABLE. UNVERIFIABLE is now reserved for genuinely abstract checks (DNS, external auth allowlists) or unreachable sibling roots.package.jsonforvalidate-*/lint-wiki/check-docsscripts and run them before falling back to UNVERIFIABLE. A passing validator promotes the item to DONE; a failing one demotes to NOT DONE.Test plan
bun test test/ship-plan-completion-invariants.test.ts— 5 assertions, ~60ms, no LLM dependency. Locks each of the four invariants against accidental rollback.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmithwith what you need.