Conversation
…port Adds model definitions for the ST CUBE WIFI WM 100L W 2400W water heater (modelId 1983) and its FLAT/S4 IOTHUB DEFAULT hub (modelId 1763). The ST CUBE exposes five distinct temperature setpoints; naming them all target_temperature produced colliding, unusable entities. They now get distinct names on this model (manual, eco+, percentage-based, eco, auxiliary), with English and French translations. Caps 105906/105907 max raised from 65 to 70 C to match what the device accepts (verified on real hardware, which reports setpoints up to 70 C). Cap 268 (v40_water_available) can now be opted out per model via a v40WaterAvailable model flag: the ST CUBE always reports 0 for it, so the entity was pure noise on this model. Other models are unaffected (flag defaults to True). Running in production on real hardware since 2026-02. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01635y2ipTY7KdjuMDvqbDtH
|
Same device, different modelId: my unit reports 1984, not 1983. I ran this branch with a one-line widening of the model gate: # model.py
elif modelId in (1983, 1984):
# capability.py — same change in all four places
if modelId in (1983, 1984):Results on my unit:
Would you consider adding 1984 to the same branch? Happy to open a separate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
target_temperatureentities — model-gated, other models unchanged; EN/FR translations includedv40WaterAvailablemodel flag to skip cap 268 per model: the ST CUBE always reports 0 for it, so the entity was pure noise. Defaults toTrue, other models unaffected.Testing
Running in production on real hardware (ST CUBE + FLAT/S4 hub) since February 2026.
🤖 Generated with Claude Code
https://claude.ai/code/session_01635y2ipTY7KdjuMDvqbDtH