FDHA: Youngs et al. (2003) primary surface displacement (AD/MD) and tests#11231
Open
vup1120 wants to merge 4 commits intogem:masterfrom
Open
FDHA: Youngs et al. (2003) primary surface displacement (AD/MD) and tests#11231vup1120 wants to merge 4 commits intogem:masterfrom
vup1120 wants to merge 4 commits intogem:masterfrom
Conversation
mmpagani
approved these changes
Feb 20, 2026
Member
mmpagani
left a comment
mmpagani
left a comment
There was a problem hiding this comment.
Apart from the comment on the rake, the PR looks good to me.
| scalar or array-like. | ||
| :param mag: | ||
| Earthquake moment magnitude (scalar). | ||
| :param style: |
Member
There was a problem hiding this comment.
I understood we wanted to use rake here. See https://github.com/gem/oq-engine/blob/master/openquake/hazardlib/valid.py#L1219 . For the youngs et al. model you need just a small utility function that takes the rake and defines the values of the style parameter accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the primary surface displacement package under openquake.fdha.primary_surf_displ, implementing the Youngs et al. (2003) model for conditional exceedance probability of primary fault displacement, plus tests and changelog.