⬆️ Bump dev dependencies + fix resulting lint errors#32
Open
gemivnet wants to merge 2 commits into
Open
Conversation
Bumps the dev group with 9 updates in the / directory: | Package | From | To | | --- | --- | --- | | [@changesets/cli](https://github.com/changesets/changesets) | `2.30.0` | `2.31.0` | | [esbuild](https://github.com/evanw/esbuild) | `0.27.4` | `0.28.0` | | [eslint](https://github.com/eslint/eslint) | `10.1.0` | `10.4.1` | | [eslint-plugin-prettier](https://github.com/prettier/eslint-plugin-prettier) | `5.5.5` | `5.5.6` | | [jest](https://github.com/jestjs/jest/tree/HEAD/packages/jest) | `30.3.0` | `30.4.2` | | [prettier](https://github.com/prettier/prettier) | `3.8.1` | `3.8.3` | | [ts-jest](https://github.com/kulshekhar/ts-jest) | `29.4.6` | `29.4.11` | | [tsx](https://github.com/privatenumber/tsx) | `4.21.0` | `4.22.4` | | [typescript-eslint](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-eslint) | `8.57.2` | `8.60.0` | Updates `@changesets/cli` from 2.30.0 to 2.31.0 - [Release notes](https://github.com/changesets/changesets/releases) - [Commits](https://github.com/changesets/changesets/compare/@changesets/cli@2.30.0...@changesets/cli@2.31.0) Updates `esbuild` from 0.27.4 to 0.28.0 - [Release notes](https://github.com/evanw/esbuild/releases) - [Changelog](https://github.com/evanw/esbuild/blob/main/CHANGELOG.md) - [Commits](evanw/esbuild@v0.27.4...v0.28.0) Updates `eslint` from 10.1.0 to 10.4.1 - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](eslint/eslint@v10.1.0...v10.4.1) Updates `eslint-plugin-prettier` from 5.5.5 to 5.5.6 - [Release notes](https://github.com/prettier/eslint-plugin-prettier/releases) - [Changelog](https://github.com/prettier/eslint-plugin-prettier/blob/main/CHANGELOG.md) - [Commits](prettier/eslint-plugin-prettier@v5.5.5...v5.5.6) Updates `jest` from 30.3.0 to 30.4.2 - [Release notes](https://github.com/jestjs/jest/releases) - [Changelog](https://github.com/jestjs/jest/blob/main/CHANGELOG.md) - [Commits](https://github.com/jestjs/jest/commits/v30.4.2/packages/jest) Updates `prettier` from 3.8.1 to 3.8.3 - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](prettier/prettier@3.8.1...3.8.3) Updates `ts-jest` from 29.4.6 to 29.4.11 - [Release notes](https://github.com/kulshekhar/ts-jest/releases) - [Changelog](https://github.com/kulshekhar/ts-jest/blob/main/CHANGELOG.md) - [Commits](kulshekhar/ts-jest@v29.4.6...v29.4.11) Updates `tsx` from 4.21.0 to 4.22.4 - [Release notes](https://github.com/privatenumber/tsx/releases) - [Changelog](https://github.com/privatenumber/tsx/blob/master/release.config.cjs) - [Commits](privatenumber/tsx@v4.21.0...v4.22.4) Updates `typescript-eslint` from 8.57.2 to 8.60.0 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/typescript-eslint/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.60.0/packages/typescript-eslint) --- updated-dependencies: - dependency-name: "@changesets/cli" dependency-version: 2.31.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev - dependency-name: esbuild dependency-version: 0.28.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev - dependency-name: eslint dependency-version: 10.4.1 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev - dependency-name: eslint-plugin-prettier dependency-version: 5.5.6 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: dev - dependency-name: jest dependency-version: 30.4.2 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev - dependency-name: prettier dependency-version: 3.8.3 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: dev - dependency-name: ts-jest dependency-version: 29.4.11 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: dev - dependency-name: tsx dependency-version: 4.22.4 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev - dependency-name: typescript-eslint dependency-version: 8.60.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev ... Signed-off-by: dependabot[bot] <support@github.com>
The dev-group dependency bump updates typescript-eslint, whose improved type inference now reports three `no-unnecessary-type-assertion` errors, failing `yarn lint` (CI's Lint & Format job): - src/connectors/market.ts: `(meta.shortName as string) ?? (meta.longName as string)` — both are already `string`. - src/core.ts: `config as unknown as Parameters<typeof recordBriefPhrase>[1]` — `config` already satisfies the parameter type. Remove the casts (type-only, no runtime change) and reformat. Verified: eslint 0 errors, prettier clean, `tsc` builds, 507/507 tests pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #31 (Dependabot dev group) — same dependency bumps, plus the lint fixes needed to make CI pass.
What
no-unnecessary-type-assertionerrors, which failedyarn linton Bump the dev group across 1 directory with 9 updates #31. Removed the three redundant casts (type-only, no runtime change):src/connectors/market.ts—(meta.shortName as string) ?? (meta.longName as string)→ both alreadystringsrc/core.ts—config as unknown as Parameters<typeof recordBriefPhrase>[1]→configalready fitspatchchangeset (per CLAUDE.md, src/ changes need one).Verified locally
yarn lint→ 0 errors (66 pre-existing style warnings remain; ESLint doesn't fail on warnings)yarn format:check→ cleanyarn build(tsc) → compilesyarn test→ 507/507 passing (21 suites)The 66 warnings are not introduced as errors and don't block CI; sweeping them is a separate opt-in cleanup if you want it.
🤖 Generated with Claude Code