Skip to content

feat: should redirect param #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cth-latest wants to merge 2 commits into from
Closed

feat: should redirect param #207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e33c9f4
feat: allow force disabling redirect
cth-latest May 3, 2025
dd9351d
chore: type definition
cth-latest May 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/react/client.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ export function AuthProvider({
);

const signIn = useCallback(
async (provider?: string, args?: FormData | Record<string, Value>) => {
async (provider?: string, args?: FormData | Record<string, Value>, shouldRedirect: boolean = true) => {
const params =
args instanceof FormData
? Array.from(args.entries()).reduce(
Expand All @@ -243,7 +243,7 @@ export function AuthProvider({
const url = new URL(result.redirect);
await storageSet(VERIFIER_STORAGE_KEY, result.verifier!);
// Do not redirect in React Native
if (window.location !== undefined) {
if (window.location !== undefined && shouldRedirect) {
window.location.href = url.toString();
}
return { signingIn: false, redirect: url };
Expand Down
6 changes: 6 additions & 0 deletions src/react/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,12 @@ export type ConvexAuthActionsContext = {
*/
code?: string;
}),
/**
* Whether to automatically redirect the user to the redirect URL.
*
* Defaults to `true`.
*/
shouldRedirect?: boolean,
): Promise<{
/**
* Whether the call led to an immediate successful sign-in.
Expand Down