Skip to content

Conversation

@HaydnTrigg
Copy link
Contributor

The check for the tomlplusplus target uses the wrong target name, so an externally provided tomlplusplus target is never detected and CMake always falls back to find_package.

It needs to use the same target name that is referenced in the adjacent target_link_libraries.

The check for the tomlplusplus target uses the wrong target name, so an externally provided tomlplusplus target is never detected and CMake always falls back to find_package.

It needs to use the same target name that is referenced in the adjacent target_link_libraries.
@gemini-code-assist
Copy link

Summary of Changes

Hello @HaydnTrigg, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a subtle but important issue in the CMake build configuration where the tomlplusplus target was not being correctly identified when provided externally. By aligning the target check with the fully qualified target name used for linking, the build system will now properly recognize existing tomlplusplus installations, streamlining the build process and avoiding redundant package searches.

Highlights

  • CMake Target Detection Fix: Corrected the target name used in the if (NOT TARGET ...) check for tomlplusplus within CMakeLists.txt to tomlplusplus::tomlplusplus.
  • Improved External Library Handling: This change ensures that an externally provided tomlplusplus target is now correctly detected by CMake, preventing it from unnecessarily falling back to find_package.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the CMakeLists.txt file to change how the tomlplusplus target is checked. Specifically, it modifies the if (NOT TARGET ...) condition from tomlplusplus to tomlplusplus::tomlplusplus, aligning the target check with the modern namespaced target usage for linking the library.

@liuzicheng1987 liuzicheng1987 merged commit 6fc8c9e into getml:main Dec 23, 2025
143 of 146 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants