Repository navigation
feat(client): sync sessions search filter to URL params - #211
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
jared | 2862e5b | Sep 19 2026, 06:43 PM |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8070530. Configure here.
Contributor
Author
Store the sessions page search query in the `search` URL param instead of local state, matching the events page. The filter now survives refresh, can be bookmarked/shared, and browser back/forward restores it. Applied on Enter/blur, cleared on Escape. Fixes #197
Add onMouseDown preventDefault to the clear button so the input keeps focus and applySearchFilter does not run before clearSearchFilter, avoiding a stray intermediate history entry.
Guard applySearchFilter so a plain focus/blur with no change does not reset page to 1 or push a duplicate history entry.
Mirror the sessions fixes on the events page repo filter: skip the commit when the value is unchanged, and preventDefault on the clear button's mousedown so onBlur does not push a duplicate history entry.
Guard clearSearchFilter/clearRepoFilter so clearing an already-empty input (e.g. Escape on a later page) does not reset pagination to page 1.
MathurAditya724
force-pushed
the
issue-197-sync-sessions-search-url
branch
from
September 19, 2026 18:43
9a041ab to
2862e5b
Compare
MathurAditya724
enabled auto-merge (squash)
September 19, 2026 18:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Stores the sessions page search query in the
searchURL param instead of localuseState, matching the events page. The filter now survives refresh, can be bookmarked/shared, and browser back/forward restores it. (Page/limit were already URL-synced.)Testing
vitest run src/client/pages/sessions.test.ts(3 passed)biome checkclean,tsc --noEmitno new errorsCloses #197