Repository navigation
ci: Let CI and Image run by hand when GitHub misses a push to main - #50
Merged
Merged
Conversation
GitHub started no push workflows for 09f6582 (#47). The Deploy run of the commit before it then saw a newer head and did not promote, so main has no CI, no image, and no deploy. Add workflow_dispatch to CI and Image, push the image on a manual run, and let Deploy accept manual runs on main. Co-Authored-By: David Cramer <23610+dcramer@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI already runs on push to
main(ci.ymlhaspush: branches: [main, "release/**"]). But GitHub started no push workflows for09f6582(the #47 merge): no CI, no Image, no CodeQL. The Deploy run of9b2ca6a(#49) then saw a newer head and stopped ("main is at 09f6582 now, not 9b2ca6a. Nothing deploys."). So the head ofmainhas no CI, no image and no deploy, and:mainstill points at6c64d29(#48). Nothing could start those runs again: neither workflow hadworkflow_dispatch.Changes
ci.ymlandimage.yml: addworkflow_dispatch.image.yml: push:<sha>on every event exceptpull_request, so a manual run onmainmakes the image.deploy.yml:promoteaccepts an Image run that isn't apull_request(push or manual). Thebranches: [main]filter still limits Deploy tomain..github/scripts/wait-for-ci.shand looks for the CI run of the commit with--branch main, not--event push. A manual CI run counts. Apull_requestrun of the same commit doesn't, because its branch isn'tmain.README.md: "Deploy" says what to run when a push gets no workflows.After merge: this merge is a new push, so it should get CI, Image and Deploy normally. If it doesn't, run
gh workflow run ci.yml --ref mainandgh workflow run image.yml --ref main.Checked
--shell=sh --enable=check-extra-masked-returns) and actionlint pass.oxfmt --checkpasses.ashwith stubgh,timeoutandsleep: success after two empty lists, a failed run, a run that never ends (60 polls, then exit 1), agherror, and no arguments (exit 2).gh run list --workflow ci.yml --branch main --commit <sha>finds the push run for9b2ca6a, nothing for09f6582, and nothing for3f11cb0(fix(server): Enforce request timeouts on servers that do not listen #49's PR head, which has only apull_requestrun).Not changed: the other inline shell in
deploy.yml(head check, VM reset, service wait). It can move to scripts in the service audit.I can't confirm why GitHub missed the push. The commit message has no skip marker, and every push workflow is missing, so it looks like a GitHub delivery gap, not this repo's config.
via @dcramer.
--
View Session [Sentry]