Repository navigation
test(key-worker): Prove the watchdog without a race with the vm timeout - #52
Merged
Merged
Conversation
"stops a key that the time limit of vm cannot stop" expected the
watchdog message. On a fast machine, `JSON.parse()` of the body ends
before the margin of 1 s, and then the `vm` timeout fails the key first
("the value patterns took over 1 ms"), as on roach#50 CI run
42061990306. A body of 900,000 keys shows it on any machine.
That test now takes either message, and still checks that the key ends
near its time limit and that the next job works. A new test stops the
worker with SIGSTOP, so only the watchdog can end the job on any
machine. It checks the watchdog message, the time that the run gets,
the time to the error, and that the next job gets a new worker. With a
margin of 20 s, it fails.
Co-Authored-By: David Cramer <23610+dcramer@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"stops a key that the time limit of vm cannot stop" expected the watchdog message. On a fast machine,
JSON.parse()of the body ends before the 1 s margin, and thevmtimeout fails the key first ("the value patterns took over 1 ms"). That is what failedteston roach#50 (run 42061990306).Only
packages/service/tests/service.test.tschanges.Checks:
pnpm checkpasses (107 tests). 5 repeated runs pass. A fast-machine simulation fails the old test with the same CI error. WithWATCHDOG_MARGIN_MS=20000, the new test fails.via @dcramer.
--
View Session [Sentry]