Repository navigation
og: rename card to og-v2.png, social tags on one line each - #37
Merged
Merged
Conversation
…each Every item on the standard Slack checklist already passed -- tags present and absolute, page 2990 bytes against a 32KB limit, no robots.txt, publicly reachable, full TLS chain, no redirects -- and Facebook, LinkedIn and opengraph.xyz all resolve the image. Only Slack does not. Two changes, for the two things that could still explain it. Rename to og-v2.png. Slack caches the image separately from the page, keyed on the image URL, so busting the page URL does not touch it. If its proxy tried og-v1.png while a region was still serving the old container it would have cached that 404. A new filename is a guaranteed miss, which is what versioning it was for. Put every social tag on a single line and move the block to the top of the head. Prettier had wrapped og:image:alt and twitter:image:alt across three lines. A proper HTML parser does not care, which is why the validators pass, but og:image:alt is a sub-property of og:image, and a line-oriented scraper that trips on it can drop the whole image property. Also adds og:image:secure_url, which is redundant over https but harmless. The smoke test asserted /og-v1.png, so it moves with the rename. Verified against the built container: every assertion passes and the old path 404s.
itsdangold
force-pushed
the
dang/og-slack
branch
from
September 18, 2026 01:19
378dcaa to
de8f197
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slack still shows the unfurl without an image. Everything checkable from outside
is correct, so this targets the two things that could still explain it.
What I ruled out first
<head>https://live.sentry.io/og-v2.pngSlackbot-LinkExpanding, no authrobots.txtimage/png, 1200×630, fully opaque, 245KBFacebook, LinkedIn and opengraph.xyz all resolve the image. Only Slack does not.
Change 1 — rename to
og-v2.pngSlack caches the image separately from the page, keyed on the image URL, so
busting the page URL with
?v=2never touched it. If Slack's proxy triedog-v1.pngwhile a region was still serving the old container during therollout, it cached that 404. A new filename is a guaranteed cache miss — which
is exactly what versioning the filename was for.
This is the one I expect to fix it.
Change 2 — one line per tag, block moved to the top of
<head>Prettier had wrapped
og:image:altandtwitter:image:altacross three lines.A real HTML parser does not care, which is why the validators pass — but
og:image:altis a sub-property ofog:image, and a line-oriented scraper thattrips on it can drop the whole image property with it. Cheap to rule out.
Also adds
og:image:secure_url(redundant over https, harmless).Verified
The smoke test asserted
/og-v1.png, so it moves with the rename — otherwisethis would have gone red like last time. Built the image and ran the step:
After merging
Delete the old Slack messages and post the link fresh — an existing message
keeps its cached unfurl regardless of what the page now says.