Repository navigation
fix(redis): Record arguments only for allowlisted commands - #3190
Closed
sentry-junior[bot] wants to merge 1 commit into
Closed
sentry-junior[bot] wants to merge 1 commit into
sentry-junior[bot] wants to merge 1 commit into
Conversation
With database query data collection enabled, every command recorded its arguments, including admin commands that carry credentials such as CONFIG SET requirepass, ACL SETUSER and MIGRATE ... AUTH. Record arguments only for commands on the allowlist from OpenTelemetry's redis-common serializer, which sentry-javascript also uses. Other commands record their command name and key. Refs SDK-1226 Co-Authored-By: Johannes Daxböck <114897+dingsdax@users.noreply.github.com>
An error occurred while trying to automatically change base from
fix/redis-redact-auth-commands
to
master
November 5, 2026 13:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3189, stacked on it.
When
data_collection.database_query_datais enabled, every Redis command records all of its arguments. Some admin commands carry credentials in those arguments, for exampleCONFIG SET requirepass <pw>,ACL SETUSER <user> ><pw>, andMIGRATE … AUTH <pw>.Arguments are now recorded only for commands that match the allowlist of command prefixes from OpenTelemetry's
redis-commonserializer, which sentry-javascript also uses. Data commands (GET/SET/HSET/EVAL/Z*, etc.) behave as before. Other commands record the command name and key only, soCONFIG SET requirepass xbecomesCONFIG SET.This only borrows the command list, not the JS per-command argument counts. For example, JS records
SET keywithout the value. The value keeps the existingdatabase_query_dataopt-in semantics here.Refs SDK-1226
via @dingsdax.
--
View Session [Sentry]