Skip to content

fix(redis): Record arguments only for allowlisted commands - #3190

Closed
sentry-junior[bot] wants to merge 1 commit into
fix/redis-redact-auth-commandsfrom
fix/redis-argument-allowlist
Closed

sentry-junior[bot] wants to merge 1 commit into
fix/redis-redact-auth-commandsfrom
fix/redis-argument-allowlist

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #3189, stacked on it.

When data_collection.database_query_data is enabled, every Redis command records all of its arguments. Some admin commands carry credentials in those arguments, for example CONFIG SET requirepass <pw>, ACL SETUSER <user> ><pw>, and MIGRATE … AUTH <pw>.

Arguments are now recorded only for commands that match the allowlist of command prefixes from OpenTelemetry's redis-common serializer, which sentry-javascript also uses. Data commands (GET/SET/HSET/EVAL/Z*, etc.) behave as before. Other commands record the command name and key only, so CONFIG SET requirepass x becomes CONFIG SET.

This only borrows the command list, not the JS per-command argument counts. For example, JS records SET key without the value. The value keeps the existing database_query_data opt-in semantics here.

Refs SDK-1226

via @dingsdax.

--

View Session [Sentry]

With database query data collection enabled, every command recorded its
arguments, including admin commands that carry credentials such as
CONFIG SET requirepass, ACL SETUSER and MIGRATE ... AUTH.

Record arguments only for commands on the allowlist from OpenTelemetry's
redis-common serializer, which sentry-javascript also uses. Other commands
record their command name and key.

Refs SDK-1226

Co-Authored-By: Johannes Daxböck <114897+dingsdax@users.noreply.github.com>
@linear-code

linear-code Bot commented Nov 5, 2026

Copy link
Copy Markdown

SDK-1226

@sentry-junior sentry-junior Bot closed this Nov 5, 2026
An error occurred while trying to automatically change base from fix/redis-redact-auth-commands to master November 5, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant