Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,8 @@ def convert_assignee_values(value: Iterable[str], projects: Sequence[Project], u
"-type": "-type",
"connectedWorkflows": "connected_workflows",
"-connectedWorkflows": "-connected_workflows",
"latestGroup": F("latest_group_date_added").asc(nulls_first=True),
"-latestGroup": F("latest_group_date_added").desc(nulls_last=True),
"latestGroup": F("latest_group_last_seen").asc(nulls_first=True),
"-latestGroup": F("latest_group_last_seen").desc(nulls_last=True),
"openIssues": F("open_issues_count").asc(nulls_first=True),
"-openIssues": F("open_issues_count").desc(nulls_last=True),
}
Expand Down Expand Up @@ -319,10 +319,10 @@ def get(
latest_detector_group_subquery = (
DetectorGroup.objects.filter(detector=OuterRef("pk"))
.order_by("-date_added")
.values("date_added")[:1]
.values("group__last_seen")[:1]
)
queryset = queryset.annotate(
latest_group_date_added=Subquery(latest_detector_group_subquery)
latest_group_last_seen=Subquery(latest_detector_group_subquery)
)
elif sort_by_field == "openIssues":
queryset = queryset.annotate(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -300,45 +300,43 @@ def test_sort_by_latest_group(self) -> None:
project=self.project, name="Detector 4 No Groups", type=MetricIssue.slug
)

group_1 = self.create_group(project=self.project)
group_2 = self.create_group(project=self.project)
group_3 = self.create_group(project=self.project)
group_1 = self.create_group(project=self.project, last_seen=before_now(hours=1))
group_2 = self.create_group(project=self.project, last_seen=before_now(hours=3))
group_3 = self.create_group(project=self.project, last_seen=before_now(hours=2))

# detector_1 has the oldest group
# The issue creation order is intentionally the opposite of the occurrence order.
detector_group_1 = DetectorGroup.objects.create(detector=detector_1, group=group_1)
detector_group_1.date_added = before_now(hours=3)
detector_group_1.save()

# detector_2 has the newest group
detector_group_2 = DetectorGroup.objects.create(detector=detector_2, group=group_2)
detector_group_2.date_added = before_now(hours=1) # Most recent
detector_group_2.date_added = before_now(hours=1)
detector_group_2.save()

# detector_3 has one in the middle
detector_group_3 = DetectorGroup.objects.create(detector=detector_3, group=group_3)
detector_group_3.date_added = before_now(hours=2)
detector_group_3.save()

# Test descending sort (newest groups first)
# Test descending sort (latest occurrences first)
response = self.get_success_response(
self.organization.slug, qs_params={"project": self.project.id, "sortBy": "-latestGroup"}
)
assert [d["name"] for d in response.data] == [
detector_2.name,
detector_3.name,
detector_1.name,
detector_3.name,
detector_2.name,
detector_4.name, # No groups, should be last
]

# Test ascending sort (oldest groups first)
# Test ascending sort (oldest occurrences first)
response2 = self.get_success_response(
self.organization.slug, qs_params={"project": self.project.id, "sortBy": "latestGroup"}
)
assert [d["name"] for d in response2.data] == [
detector_4.name, # No groups, should be first
detector_1.name,
detector_3.name,
detector_2.name,
detector_3.name,
detector_1.name,
]

def test_sort_by_open_issues(self) -> None:
Expand Down
Loading