fix(elf): Fix potential out of bounds panic on invalid section offsets#1013
Merged
Conversation
Dav1dde
force-pushed
the
dav1d/fix-out-of-bounds-panic
branch
from
6704934 to
81d5e27
Compare
loewenheim
approved these changes
Jul 7, 2026
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Fixes
- Fix potential out of bounds panic on invalid section offsets ([#1013](https://github.com/getsentry/symbolic/pull/1013))If none of the above apply, you can opt out of this check by adding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: INGEST-989
This returns
Noneif there is a matching section but with incorrect offsets, which I think is reasonable. The alternative is to keep searching, but is it really expected to find another section with the same name but no broken offsets?