Finish migration from maxInterStageShaderComponents to maxInterStageShaderVariables
#8652
+225
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimblandy
changed the title
maxInterStageShaderComponents to maxInterStageShaderVariables` maxInterStageShaderComponents to maxInterStageShaderVariables
ErichDonGubler
force-pushed
the
max-inter-stage-shader-variables
branch
3 times, most recently
from
312ac16 to
a7a3a4d
Compare
TODO: split movement of `enum` mapping out TODO: explain - Prep for a new `enum` later, `naga::ShaderStage` is the closest thing.
ErichDonGubler
force-pushed
the
max-inter-stage-shader-variables
branch
from
a7a3a4d to
40c5180
Compare
TODO: explain - bundle state needed into same place - Discovery: `compare_function` was being provided, but not checked, in other places. Intentional?
- add `StageError::VertexOutputLocationTooLarge` - add `StageError::TooManyVertexOutputs` - add `MaxInterStageShaderVariablesDeductions`
ErichDonGubler
force-pushed
the
max-inter-stage-shader-variables
branch
from
40c5180 to
b948e13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
maxInterStageShaderVariableswas originally discussed for introduction to the WebGPU spec. committee at Should we constrain the location of user input-output stage variables WGSL gpuweb/gpuweb#1962.maxInterStageShaderVariableswas proposed to outright supersedemaxInterStageShaderComponentswith maxInterStageShaderComponents seems to overlap with maxInterStageShaderVariables gpuweb/gpuweb#4688.Description
TODO
Testing
TBD.
Squash or Rebase?
TBD.
Checklist
CHANGELOG.mdentry.