Downgrade ron to 0.11.0 to avoid new dependencies. #8702
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently other components in Firefox are using ron 0.11.0. Ron 0.12 looks fine, but it adds a dependency on the typeid crate, which seems tricky to audit. We can do this, but for the sake of allowing Firefox to take critical wgpu updates, we should put it off for a bit.
Member
|
RE: |
cwfitzgerald
requested changes
Dec 10, 2025
Member
cwfitzgerald
left a comment
cwfitzgerald
left a comment
There was a problem hiding this comment.
Since it seems like no code changes are needed, could we take a range dependency?
Member
Author
|
Actually, I think I understand what ron 0.12 is doing now, and I've read typeid, so I think we can just take the upgrade. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently other components in Firefox are using ron 0.11.0. Ron 0.12 looks fine, but it adds a dependency on the typeid crate, which seems tricky to audit. We can do this, but for the sake of allowing Firefox to take critical wgpu updates, we should put it off for a bit.