Migrate from Ruby Danger to danger-kotlin - #329
Merged
Conversation
ggrell
force-pushed
the
claude/migrate-danger-kotlin-9ncWB
branch
3 times, most recently
from
March 30, 2026 11:40
5ff9c3d to
38d41dd
Compare
- Replace MeilCli/danger-action (Ruby) with danger/kotlin@1.3.4 - Add Dangerfile.df.kts with plugins for detekt, Android lint, JUnit, and Kotlin compiler warning parsing from build log - Add basePath to detekt config for inline PR comments to work - Enable xmlReport on all 4 Android modules so lint reports are generated - Capture build output via tee build.log for Kotlin warning extraction - Remove ruby/setup-ruby step and BUNDLE_GEMFILE env var - Add pull-requests: write permission for built-in GITHUB_TOKEN - Delete old .github/Dangerfile and .github/Gemfile https://claude.ai/code/session_01Si4u1D3ooHG7PxctV5ZRf9
- Fix detekt.yml: remove deprecated ignoreOverridden properties, rename MandatoryBracesIfStatements→BracesOnIfStatements and OptionalWhenBraces→BracesOnWhenStatements, update ForbiddenComment to new comments format, enable warningsAsErrors - Fix Kotlin shadow-variable warnings in Reactor.kt across all three rxreactor modules (rename lambda params to avoid shadowing) - Fix ReactorWithEffects: use effect.asIterable() for Observable.from() - Fix LoginActivity: use typed getParcelable() API, remove redundant qualifier - Add monochrome icon to adaptive-icon XMLs (MonochromeLauncherIcon lint) - Update kotlin-warning-matcher.json for K2 compiler warning format (w: file:line:col msg instead of w: file: (line, col): msg) - Update Dangerfile.df.kts regex to match K2 warning format - Update CLAUDE.md: replace obsolete Ruby Danger note with danger-kotlin docs https://claude.ai/code/session_01Si4u1D3ooHG7PxctV5ZRf9
- Move register plugin calls outside danger(args) block (required by danger-kotlin API) - Fix DetektConfig import: io.github.ackeecz.danger.lint.detekt.DetektConfig - Fix JUnitConfig import: io.github.ackeecz.danger.testing.junit.JUnitConfig - Remove non-existent BuildFoldersMatcher and DetektConfig.Discovery (these classes don't exist in the library; DetektConfig() default is sufficient) https://claude.ai/code/session_01Si4u1D3ooHG7PxctV5ZRf9
ggrell
force-pushed
the
claude/migrate-danger-kotlin-9ncWB
branch
from
March 30, 2026 15:04
38d41dd to
b5d5d05
Compare
Generated by 🚫 Danger Kotlin against 65e56f6 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #329 +/- ##
=========================================
Coverage 88.11% 88.11%
Complexity 50 50
=========================================
Files 9 9
Lines 101 101
=========================================
Hits 89 89
Misses 12 12 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and Kotlin compiler warning parsing from build log
https://claude.ai/code/session_01Si4u1D3ooHG7PxctV5ZRf9