Skip to content

Remove ZFS-related tunable from create_cfg.py#85

Merged
ericbsd merged 1 commit into
masterfrom
remove-zfs-tunnable
Aug 20, 2025
Merged

Remove ZFS-related tunable from create_cfg.py#85
ericbsd merged 1 commit into
masterfrom
remove-zfs-tunnable

Conversation

@ericbsd
Copy link
Copy Markdown
Contributor

@ericbsd ericbsd commented Aug 20, 2025

Summary by Sourcery

Bug Fixes:

  • Remove conditional block that appended 'vfs.zfs.arc.sys_free' setting to /boot/loader.conf

@ericbsd ericbsd requested review from a team as code owners August 20, 2025 23:26
@ericbsd ericbsd self-assigned this Aug 20, 2025
@ericbsd ericbsd requested review from a team as code owners August 20, 2025 23:26
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Aug 20, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR simplifies create_cfg.py by removing the ZFS ARC sys_free tunable injection logic that appended a configuration line to /boot/loader.conf when zfs support was enabled.

Class diagram for updated configuration logic in create_cfg.py

classDiagram
    class CreateCfg {
        __init__()
        # Removed: zfs ARC sys_free tunable injection
    }
Loading

File-Level Changes

Change Details Files
Remove ZFS ARC sys_free tunable write logic
  • Deleted the conditional check for zfs flag
  • Removed definition of the zfs_arc command
  • Erased the runCommand write invoking zfs_arc
src/create_cfg.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ericbsd ericbsd merged commit 2eb9116 into master Aug 20, 2025
2 checks passed
@ericbsd ericbsd deleted the remove-zfs-tunnable branch August 20, 2025 23:27
@github-project-automation github-project-automation Bot moved this from In Review to Done in Development Tracker Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants