Skip to content

Update RADEON and NVIDIA driver support#55

Merged
ericbsd merged 2 commits into
masterfrom
update-drivers
May 2, 2026
Merged

Update RADEON and NVIDIA driver support#55
ericbsd merged 2 commits into
masterfrom
update-drivers

Conversation

@ericbsd
Copy link
Copy Markdown
Contributor

@ericbsd ericbsd commented May 2, 2026

  • Add support for NVIDIA 580 driver detection and installation
  • Refactor RADEON_DEVICE IDs for improved AMD GPU compatibility
  • Update menu options and helper functions to include NVIDIA 580
  • Delete NVIDIA 304 driver detection, setup, and menu options
  • Simplify legacy driver handling by focusing on supported versions

Summary by Sourcery

Update GPU driver handling to focus on current NVIDIA and AMD support while simplifying legacy paths.

New Features:

  • Add detection and installation support for the NVIDIA 580 driver, including menu and helper integration.

Enhancements:

  • Refactor RADEON device ID handling to improve AMD GPU compatibility and streamline configuration logic.
  • Simplify legacy NVIDIA driver handling by removing unsupported versions and consolidating supported-driver paths.

Chores:

  • Remove NVIDIA 304 driver detection, setup, and related menu options as it is no longer supported.

ericbsd added 2 commits April 26, 2026 22:19
- Add support for NVIDIA 580 driver detection and installation
- Refactor `RADEON_DEVICE` IDs for improved AMD GPU compatibility
- Update menu options and helper functions to include NVIDIA 580
- Delete NVIDIA 304 driver detection, setup, and menu options
- Simplify legacy driver handling by focusing on supported versions
@ericbsd ericbsd requested review from a team as code owners May 2, 2026 03:11
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented May 2, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates GPU driver management in xconfig by adding NVIDIA 580 support, refactoring AMD RADEON device IDs, and simplifying legacy NVIDIA driver handling while removing the deprecated 304 driver path.

File-Level Changes

Change Details Files
Add detection, installation, and menu integration for the NVIDIA 580 driver.
  • Introduce logic to detect NVIDIA 580-capable hardware
  • Add installation/configuration path for the NVIDIA 580 driver
  • Extend menu options and helper routines to expose NVIDIA 580 as a selectable driver
bin/xconfig
Refactor RADEON device ID handling to improve AMD GPU compatibility.
  • Consolidate or update RADEON_DEVICE ID tables/mappings
  • Adjust detection logic to use the updated RADEON_DEVICE definitions
  • Ensure AMD GPU paths align with the new device ID structure
bin/xconfig
Remove legacy NVIDIA 304 driver handling and simplify legacy driver code paths.
  • Delete NVIDIA 304 detection and installation/setup routines
  • Remove menu entries and options referencing NVIDIA 304
  • Simplify legacy/unsupported NVIDIA driver branches to focus on supported versions only
bin/xconfig

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ericbsd ericbsd merged commit 1b5e96c into master May 2, 2026
2 checks passed
@ericbsd ericbsd deleted the update-drivers branch May 2, 2026 03:12
@github-project-automation github-project-automation Bot moved this from In Review to Done in Development Tracker May 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants