Eliminate all CI lint and test warnings#106
Merged
Merged
Conversation
Lint (302 warnings -> 0): - Remove unused imports, dead variables and write-only counters - Use optional catch bindings for unused catch params - Escape literal quotes in JSX text, add missing display names - Remove dead DEBUG_STORAGE blocks and useless regex escapes - Enable react/jsx-uses-vars for test files so JSX usage counts (previously 108 false-positive no-unused-vars in tests) Test output (~60 console messages -> 0): - Wrap async storage/lazy-load updates in act() across six component test suites (FPContentArea, CollectionListItem, CollectionDetailPanel, SyncDebugRecoveryPanel, CollectionListOptions, MoveToCollectionModal) - Spy on console.warn/error in tests that deliberately exercise warning paths, asserting the warning fired where meaningful No production behavior changes; 950 tests pass, yarn prod builds. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI was emitting ~300 ESLint warnings and ~60 console warnings during the Jest run. This PR brings both to zero with no production behavior changes.
Lint (302 → 0)
DEBUG_STORAGEblocks deletedreact/jsx-uses-varsin the test-files ESLint block — 108 of the warnings were false positives where ESLint couldn't see imports used as JSX in testsTest output (~60 → 0)
act(...)warnings in 6 component suites by awaiting async storage reads and lazy-loaded modals insideact()— no assertions changedconsole.warn/console.errorand assert the warning fired where meaningful; no global silencer was addedVerification
yarn lint— clean, zero warningsyarn test— 126 suites, 950 tests pass; zeroconsole.warn/console.error, zero act() warningsyarn prod— compiles successfully🤖 Generated with Claude Code