Skip store publish when the live version matches the manifest#108
Merged
Conversation
Both stores reject re-uploads of an already-published version, so the publish steps now check the public listing version first (Chrome's update service / Edge's product-details endpoint) and exit cleanly on a match. Lookup failures fall through to the store API. This keeps main green on merges that don't bump the manifest version. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every merge to main without a manifest version bump currently produces a red Chrome publish step (the store rejects re-uploads of the live version —
PKG_INVALID_VERSION_NUMBER). Both publish steps now check the publicly available live version first and skip cleanly when it equals the manifest version:clients2.google.com/service/update2/crx)Fail-open by design: if the version lookup fails or returns nothing, the step proceeds and lets the store API decide. The Edge listing lags while a submission is in review, so the guard only catches the fully-published case — an in-review duplicate still surfaces as an API error, which is the correct signal.
Verified both endpoints locally: Chrome returns 4.1.2 (live), Edge returns 3.5.9 (4.1.2 currently in review).
🤖 Generated with Claude Code