Repository navigation
feat: mention a missing or outdated GiottoKernels once per session - #136
Merged
Merged
Conversation
The R fallback is unchanged; the message gives the r-universe install. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GiottoKernels was silent when missing:
.gd_kernel()fell back to the R path, so a user never found out the compiled kernels exist. The first step that would use a kernel (gram-eigen PCA passes, edge pairs and products) now says so, once per session:An installed GiottoKernels below the 0.3.0 Suggests floor gets one notice too. Before, kernels it lacked (such as
edge_products_stream) were skipped without a word.package_check(on_missing = "message", once = TRUE)from GiottoUtils 0.2.9 (feat: package_check() on_missing levels and once GiottoUtils#193), soImports: GiottoUtils (>= 0.2.9).Remotes:already takes GiottoUtils from@dev.options(giottodisk.use_kernels = FALSE)skips the check entirely.Tests: a fake package is mentioned once and then silent, and
use_kernels = FALSEnever reaches the check.devtools::test(filter = "utils-edge|stream-pca")gives 0 failures and 163 passing. The 1 skip is theedge_products_streamkernel test, because the local GiottoKernels is 0.2.0.🤖 Generated with Claude Code