Repository navigation
Local viewer builds go to an untracked inst/viewer-dev/ - #16
Merged
Merged
Conversation
`npm run build:dev` writes inst/viewer-dev/ (gitignored, Rbuildignored), and .viewer_dir() serves it while it is newer than the committed inst/viewer/, so local builds no longer dirty the tracked bundle. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building the viewer locally rewrote the committed bundle in
inst/viewer/, so every local build had to be undone withgit restore inst/viewerbefore committing. A.gitignoreentry can't fix that: the bundle is tracked, so its changed and deleted files still show, and CI'sgit add -A inst/viewerwould refuse an ignored path.npm run build:devwritesinst/viewer-dev/, which is in.gitignoreand.Rbuildignore..viewer_dir()servesinst/viewer-dev/while itsindex.htmlis newer thaninst/viewer/'s. Otherwise it serves the committed bundle. A pull that updates the committed bundle makes that bundle the newer one, so a stale local build isn't served.npm run buildand CI are unchanged.AGENTS.md,READMEand the change checklist now point tobuild:dev.Tests: a new server test covers which bundle is chosen. The server and e2e tests pass with
load_all()servinginst/viewer-dev/. The intermittent "rules are visible" e2e test failed in one run and passed in the next four.🤖 Generated with Claude Code