[codex] migrate Codex preset to hooks and shared bash recovery#997
Merged
svarlamov merged 3 commits intojohnw/bash-supportfrom Apr 7, 2026
Merged
Conversation
|
Test Runner seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
01b6d04 to
df2c831
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Codex now supports bash pre/post hooks, but it still does not emit hooks for file-edit tool calls. The old notify-based path needed to be removed, while commit-time attribution still needed to recover the owning Codex session when git commit happens inside a live bash invocation.
This change moves that recovery into the shared bash snapshot flow so other agents can use the same mechanism, and leaves Codex-specific logic only for the current runtime gaps.
User impact
Validation
Stack
Base branch:
johnw/bash-supportIntended follow-up into: #798