Prepare some more for the split mingw-w64-git package
#663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of the effort to upstream `mingw-w64-git` to MSYS2, I changed the default to _not_ build `.pdb` files by default (because MSYS2 lacks the `mingw-w64-cv2pdb` package, and it is unlikely that they would accept it either, given that it requires MSBuild and Visual C to build). That means that one no longer sets `WITHOUT_PDBS` when skipping `mingw-w64-pdb`, but `WITH_PDBS` when including it in the build. For the transition period, ensure that the `mingw-w64-git` package of Git for Windows is built using the correct value for those flags, depending whether the DLLs required by cv2pdb are found or not. Signed-off-by: Johannes Schindelin <[email protected]>
There is logic to skip building the `.pdb` files of `mingw-w64-git` and `mingw-w64-curl` in Git for Windows' package definitions. However, while upstreaming `mingw-w64-git` to the MSYS2 project, it became obvious that the default should not be to build those `.pdb` files, and therefore the flag should not be called `WITHOUT_PDBS`, but instead the default should be to skip them and the flag should be named `WITH_PDBS`. Let's handle both flags when `sdk build`ing packages. Signed-off-by: Johannes Schindelin <[email protected]>
Member
Author
|
/updpkgsums The workflow run was started. |
Signed-off-by: Johannes Schindelin <[email protected]>
rimrul
approved these changes
Nov 25, 2025
This comment has been minimized.
This comment has been minimized.
Member
Author
|
/deploy git-extra The i686/x86_64 and the arm64 workflow runs were started. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of my effort to upstream the
mingw-w64-gitpackage definition to MSYS2, I had to change the default to omit buildingmingw-w64-git-pdb. Before marking the upstreaming PR as ready for review, I want to ensure that Git for Windows already has the identical changes (see git-for-windows/MINGW-packages#174). This requires two changes inbuild-extrato accommodate for the now-inverted logic.