Skip to content

Replace static assertion batch 3#659

Merged
flyingrobots merged 2 commits into
mainfrom
v18-catchup-batch-3
Jun 18, 2026
Merged

Replace static assertion batch 3#659
flyingrobots merged 2 commits into
mainfrom
v18-catchup-batch-3

Conversation

@flyingrobots

@flyingrobots flyingrobots commented Jun 18, 2026

Copy link
Copy Markdown
Member

Summary

  • Replace the batch-3 static source assertions with behavior-oriented tests for public reading surfaces, V17 migration scripts, WARP drift documentation, and the V7 schema-2 contract.
  • Add a focused V7 dead-file guard so retired schema-1 and legacy engine files cannot quietly return.
  • Preserve historical design/retro witness truth while documenting current successor coverage for retired ratchets.
  • Reuse the shared MarkdownDocument helper in the WARP drift doc graph test.

Issues

Closes #348.
Closes #349.
Closes #350.
Closes #351.
Closes #352.
Closes #353.
Closes #354.
Closes #355.
Closes #356.
Closes #357.

Validation

  • npm exec vitest run test/unit/domain/publicReadingSurface.behavior.test.ts test/unit/scripts/warp-drift-doc-graph.test.ts test/unit/scripts/v7-dead-file-guard.test.ts test/unit/v7-guards.test.ts test/unit/scripts/v17-migration-script-behavior.test.ts test/unit/scripts/glossary-shape.test.ts test/unit/scripts/observer-geometry-ladder-shape.test.ts test/unit/scripts/openwarpgraph-composition-root.test.ts
  • npm run typecheck --silent
  • npm run lint --silent
  • npm run lint:md --silent
  • npm run lint:md:code --silent
  • npm run lint:links --silent
  • npm run lint:quarantine-graduate --silent
  • npm run typecheck:consumer --silent
  • npm run typecheck:surface --silent
  • git diff --check
  • Pre-push IRONCLAD M9: link check, static gates, and stable unit-test shards all passed.

@codex please confirm that the historical witness wording now distinguishes retired cycle-close ratchets from current successor coverage.

@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@flyingrobots, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 20 minutes and 44 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ee4df134-13d1-4bbd-a856-425df905089f

📥 Commits

Reviewing files that changed from the base of the PR and between 7d8f920 and 823c544.

📒 Files selected for processing (19)
  • docs/design/0036-warp-drift-ledger-crosslinks.md
  • docs/design/0037-remaining-warp-drift-release-slotting.md
  • docs/method/retro/0036-warp-drift-ledger-crosslinks/warp-drift-ledger-crosslinks.md
  • docs/method/retro/0037-remaining-warp-drift-release-slotting/remaining-warp-drift-release-slotting.md
  • docs/method/retro/0076-delete-warpcore-runtime-bridge/delete-warpcore-runtime-bridge.md
  • test/unit/domain/publicReadingSurface.behavior.test.ts
  • test/unit/scripts/v17-migration-script-behavior.test.ts
  • test/unit/scripts/v17-migration-script-hygiene.test.ts
  • test/unit/scripts/v17-public-reading-surface.test.ts
  • test/unit/scripts/v17-worldline-reading-surface.test.ts
  • test/unit/scripts/v7-dead-file-guard.test.ts
  • test/unit/scripts/warp-drift-crosslinks-shape.test.ts
  • test/unit/scripts/warp-drift-doc-graph.test.ts
  • test/unit/scripts/warp-drift-release-slotting-shape.test.ts
  • test/unit/scripts/warpapp-capability-bridge.test.ts
  • test/unit/scripts/warpcore-runtime-bridge.test.ts
  • test/unit/scripts/warpgraph-capability-seam.test.ts
  • test/unit/scripts/warpgraph-factory-closeout.test.ts
  • test/unit/v7-guards.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch v18-catchup-batch-3

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown

Release Preflight

  • package version: 18.0.0
  • prerelease: false
  • npm dist-tag on release: latest
  • npm pack dry-run: passed
  • jsr publish dry-run: passed

If you tag this commit as v18.0.0, release workflow will publish.

@flyingrobots

Copy link
Copy Markdown
Member Author

Code Lawyer Activity Summary

# Source Severity File / Area Commit Outcome
1 PR review threads P0-P5 n/a n/a No review threads returned by GraphQL; nothing to resolve.
2 PR global comments P4 CodeRabbit / release preflight n/a CodeRabbit reported review limit / skipped review; release preflight passed. No code action.
3 Self-audit P0-P5 origin/main...HEAD n/a No new self-discovered defects after full diff, graft structural diff, export diff, and targeted ratchet-equivalence audit.

Evidence

  • Thread-aware GraphQL query returned reviewThreads.nodes: [] and reviews.nodes: [].
  • gh pr checks 659 is green across CI, link check, issue reference, coverage, release preflight, and CodeRabbit status.
  • Local worktree is clean against origin/main; branch contains ae64189f and 823c5441.
  • No additional commits were required in this audit pass.

Merge Gate Judgment

Locked: CI is green, but the PR currently has 0 approvals. CodeRabbit also produced a rate-limit/skipped-review comment rather than substantive review feedback.

@flyingrobots flyingrobots merged commit 5e3fe79 into main Jun 18, 2026
17 of 18 checks passed
@flyingrobots flyingrobots deleted the v18-catchup-batch-3 branch June 18, 2026 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment