Run integration suite on node:test with real Probot 14

[decyjphr]

Probot 14 is ESM-only, so the Jest integration suite could no longer load it (SyntaxError: Unexpected token 'export') and all 7 suites failed before running a single test. This moves test/integration to node:test while keeping the unit suite on Jest. The integration tests were lightly coupled to Jest (hooks, assertions, Nock, real Probot instances), so the migration preserves the existing coverage instead of replacing it with simplified transport tests.

Approach

• Async loading: loadInstance() dynamically imports probot, awaits probot.load(), and waits for the app's startup GET /app/installations call (from the un-awaited info()) so it cannot race with per-test scopes. createProbot gets env: {} so a developer's APP_ID / PRIVATE_KEY / GHE_HOST can't change credentials or base URL.
• Nock preserved: fixtures and nock.disableNetConnect() are unchanged. Teardown asserts every expected request happened, listing pending mocks and any request-body mismatches, and always runs nock.cleanAll() / mock.restoreAll() for isolation.
• Fail on unexpected errors: Probot gets a recording pino-compatible logger; any error/fatal log or console.error fails the test, including errors the app catches and logs. LOG_LEVEL echoes logs to stderr for debugging.
• Body assertions: expect(body).toMatchObject(...) inside Nock matchers is replaced by a bodyMatching() helper with equivalent semantics.
• Transport check: new transport.test.js verifies Nock intercepts the Probot Octokit fetch transport the app uses, and that unmocked requests are blocked.
• CI: test:integration:ci (creates reports/, emits spec output plus JUnit to reports/integration-junit.xml) now runs in node-ci.yml on Node 22 and 24, and the JUnit report is uploaded as an artifact even on failure. Jest now ignores test/integration.
• Separate compat fix: the repository test used yaml.safeLoad, removed in js-yaml v4; it now uses yaml.load (own commit).

Fixture updates

Once loading worked, fixtures no longer matched current app behavior. They now:

• Send complete webhook payloads (owner login, organization, sender, installation); plugin tests use a deterministic repository.created trigger instead of a random one.
• Serve org config from the admin repo (<org>/admin/.github/settings.yml) and mock the suborg lookup, repo-config directory, admin commit, and check-run requests the app now makes.
• Match current Octokit endpoints (org-scoped team repo URLs, collaborator invitations, GET before PATCH on the repo).
• Replace the stale "default branch not changed" repository.edited case with one asserting bot-generated edits are ignored.

Status and review notes

All 10 integration tests pass locally on Node 22; the unit suite (Jest), test:pagination, and lint on test/integration also pass. Node 24 is first exercised by this PR's CI run.

lib/proxyAwareProbotOctokit.js (used by handler.js) cannot be required with the installed ESM-only Octokit plugins, so it is not covered by the transport test. That is a separate, pre-existing issue.

[Copilot]

Copilot review overview

🟡 Changes recommended

The integration command remains red, and JUnit reporting fails when the absent reports directory is used.

Review effort: Balanced
Findings: 2

Open (2)

• Fix failing integration fixtures before enabling CI · New
• Create reports directory before writing JUnit output · New

What changed in this PR

Migrates integration tests from Jest to node:test for Probot 14 compatibility.

Changes:

• Adds async Probot loading, request matching, logging, and teardown helpers.
• Migrates integration suites and adds transport coverage.
• Adds Node test scripts, JUnit reporting, and Jest exclusions.

File	Description
package.json	Configures Node integration tests and Jest exclusions.
test/​integration/​common.js	Adds Probot 14 loading and test utilities.
test/​integration/​transport.test.js	Verifies Nock interception and network blocking.
test/​integration/​triggers/​push.test.js	Migrates push tests to node:test.
test/​integration/​triggers/​repository-created.test.js	Migrates repository-created tests.
test/​integration/​triggers/​repository-edited.test.js	Migrates repository-edited tests.
test/​integration/​plugins/​collaborators.test.js	Migrates collaborator tests and body assertions.
test/​integration/​plugins/​milestones.test.js	Migrates milestone tests and body assertions.
test/​integration/​plugins/​repository.test.js	Migrates repository tests and updates YAML loading.
test/​integration/​plugins/​teams.test.js	Migrates team tests and body assertions.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Copilot review overview

🟡 Changes recommended

The migrated integration suite is not invoked by the pull-request CI workflow.

Review effort: Balanced
Findings: 1

Open (1)

• Add integration tests to the CI workflow · New

Resolved since last review (2)

• Create reports directory before writing JUnit output
• Fix failing integration fixtures before enabling CI