Skip to content

fix(a11y): add labels and non-color activity cue #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
karpikpl wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(a11y): add labels and non-color activity cue #427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d63f2a0
fix(a11y): add aria-labels to icon buttons and non-color cue to activ…
karpikpl Jul 14, 2026
5838c71
fix(a11y test): loop-based tag stripper to satisfy CodeQL (#422)
karpikpl Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/components/AdminPanel.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<v-icon color="primary">mdi-shield-crown</v-icon>
Admin Panel
<v-spacer />
<v-btn icon variant="text" size="small" title="Close" @click="isOpen = false">
<v-btn icon variant="text" size="small" title="Close" aria-label="Close admin panel" @click="isOpen = false">
<v-icon>mdi-close</v-icon>
</v-btn>
</v-card-title>
Expand Down Expand Up @@ -249,6 +249,7 @@
variant="text"
icon
title="Retry this date"
aria-label="Retry this date"
:loading="retryingDate === f.metricsDate"
:disabled="!!busyAction"
@click="retryOne(f.metricsDate)"
Expand Down Expand Up @@ -431,6 +432,7 @@
variant="text"
density="compact"
title="Dismiss this row (kept in DB so gap-mode coverage still works)"
aria-label="Dismiss billing job row"
@click="dismissBillingJob(j.id)"
/>
</td>
Expand Down
6 changes: 3 additions & 3 deletions app/components/AgentActivityViewer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,9 @@
<v-container :fluid="chartColumns === 'full'" :class="['elevation-2', chartColumns === 'full' ? 'px-0' : 'px-4']">
<div class="d-flex justify-end mb-2">
<v-btn-toggle v-model="chartColumns" density="compact" variant="outlined" mandatory>
<v-btn value="1" size="small" title="Single column"><v-icon size="18">mdi-view-agenda</v-icon></v-btn>
<v-btn value="2" size="small" title="Two columns"><v-icon size="18">mdi-view-grid</v-icon></v-btn>
<v-btn value="full" size="small" title="Full width"><v-icon size="18">mdi-fullscreen</v-icon></v-btn>
<v-btn value="1" size="small" title="Single column" aria-label="Single column layout"><v-icon size="18">mdi-view-agenda</v-icon></v-btn>
<v-btn value="2" size="small" title="Two columns" aria-label="Two column layout"><v-icon size="18">mdi-view-grid</v-icon></v-btn>
<v-btn value="full" size="small" title="Full width" aria-label="Full width layout"><v-icon size="18">mdi-fullscreen</v-icon></v-btn>
</v-btn-toggle>
</div>

Expand Down
6 changes: 3 additions & 3 deletions app/components/AgentModeViewer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,9 @@
<v-container :fluid="chartColumns === 'full'" :class="['elevation-2', chartColumns === 'full' ? 'px-0' : 'px-4']">
<div class="d-flex justify-end mb-2">
<v-btn-toggle v-model="chartColumns" density="compact" variant="outlined" mandatory>
<v-btn value="1" size="small" title="Single column"><v-icon size="18">mdi-view-agenda</v-icon></v-btn>
<v-btn value="2" size="small" title="Two columns"><v-icon size="18">mdi-view-grid</v-icon></v-btn>
<v-btn value="full" size="small" title="Full width"><v-icon size="18">mdi-fullscreen</v-icon></v-btn>
<v-btn value="1" size="small" title="Single column" aria-label="Single column layout"><v-icon size="18">mdi-view-agenda</v-icon></v-btn>
<v-btn value="2" size="small" title="Two columns" aria-label="Two column layout"><v-icon size="18">mdi-view-grid</v-icon></v-btn>
<v-btn value="full" size="small" title="Full width" aria-label="Full width layout"><v-icon size="18">mdi-fullscreen</v-icon></v-btn>
</v-btn-toggle>
</div>

Expand Down
8 changes: 5 additions & 3 deletions app/components/AiChatPanel.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
class="ai-chat-fab"
color="indigo"
icon
aria-label="Open AI metrics assistant"
size="large"
elevation="6"
style="position: fixed; bottom: 24px; right: 24px; z-index: 2147483647;"
Expand All @@ -31,15 +32,15 @@
AI Metrics Assistant
</v-toolbar-title>
<v-spacer />
<v-btn v-if="userToken" icon size="small" variant="text" @click="clearUserToken" title="Disconnect token">
<v-btn v-if="userToken" icon size="small" variant="text" aria-label="Disconnect personal token" @click="clearUserToken" title="Disconnect token">
<v-icon size="small">mdi-key-remove</v-icon>
<v-tooltip activator="parent" :z-index="2147483647" location="bottom">Disconnect personal token</v-tooltip>
</v-btn>
<v-btn icon size="small" variant="text" @click="clearConversation">
<v-btn icon size="small" variant="text" aria-label="Clear conversation" @click="clearConversation">
<v-icon size="small">mdi-delete-outline</v-icon>
<v-tooltip activator="parent" :z-index="2147483647" location="bottom">Clear conversation</v-tooltip>
</v-btn>
<v-btn icon size="small" variant="text" @click="isOpen = false">
<v-btn icon size="small" variant="text" aria-label="Close AI metrics assistant" @click="isOpen = false">
<v-icon size="small">mdi-close</v-icon>
</v-btn>
</v-toolbar>
Expand Down Expand Up @@ -185,6 +186,7 @@
<template #append-inner>
<v-btn
icon
aria-label="Send message"
size="small"
variant="text"
color="indigo"
Expand Down
6 changes: 3 additions & 3 deletions app/components/BreakdownComponent.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,9 @@
<v-container :fluid="chartColumns === 'full'" :class="[chartColumns === 'full' ? 'px-0' : 'px-4']">
<div class="d-flex justify-end mb-2">
<v-btn-toggle v-model="chartColumns" density="compact" variant="outlined" mandatory>
<v-btn value="1" size="small" title="Single column"><v-icon size="18">mdi-view-agenda</v-icon></v-btn>
<v-btn value="2" size="small" title="Two columns"><v-icon size="18">mdi-view-grid</v-icon></v-btn>
<v-btn value="full" size="small" title="Full width"><v-icon size="18">mdi-fullscreen</v-icon></v-btn>
<v-btn value="1" size="small" title="Single column" aria-label="Single column layout"><v-icon size="18">mdi-view-agenda</v-icon></v-btn>
<v-btn value="2" size="small" title="Two columns" aria-label="Two column layout"><v-icon size="18">mdi-view-grid</v-icon></v-btn>
<v-btn value="full" size="small" title="Full width" aria-label="Full width layout"><v-icon size="18">mdi-fullscreen</v-icon></v-btn>
</v-btn-toggle>
</div>
<!-- CLI summary card (editors tab only) -->
Expand Down
6 changes: 3 additions & 3 deletions app/components/CopilotChatViewer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,9 @@
<v-container :fluid="chartColumns === 'full'" :class="['elevation-2', chartColumns === 'full' ? 'px-0' : 'px-4']">
<div class="d-flex justify-end mb-2">
<v-btn-toggle v-model="chartColumns" density="compact" variant="outlined" mandatory>
<v-btn value="1" size="small" title="Single column"><v-icon size="18">mdi-view-agenda</v-icon></v-btn>
<v-btn value="2" size="small" title="Two columns"><v-icon size="18">mdi-view-grid</v-icon></v-btn>
<v-btn value="full" size="small" title="Full width"><v-icon size="18">mdi-fullscreen</v-icon></v-btn>
<v-btn value="1" size="small" title="Single column" aria-label="Single column layout"><v-icon size="18">mdi-view-agenda</v-icon></v-btn>
<v-btn value="2" size="small" title="Two columns" aria-label="Two column layout"><v-icon size="18">mdi-view-grid</v-icon></v-btn>
<v-btn value="full" size="small" title="Full width" aria-label="Full width layout"><v-icon size="18">mdi-fullscreen</v-icon></v-btn>
</v-btn-toggle>
</div>
<v-row>
Expand Down
9 changes: 5 additions & 4 deletions app/components/MainComponent.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,29 @@
<template>
<div>
<v-toolbar color="transparent" elevation="0" class="app-toolbar">
<v-btn icon>
<v-btn icon aria-label="GitHub Copilot Metrics Viewer home">
<v-icon>mdi-github</v-icon>
</v-btn>

<v-toolbar-title class="toolbar-title">{{ displayName }}</v-toolbar-title>
<h2 class="error-message"> {{ mockedDataMessage }} </h2>
<v-spacer />

<v-btn icon :title="showDateRange ? 'Hide date range' : 'Show date range'" @click="showDateRange = !showDateRange">
<v-btn icon :title="showDateRange ? 'Hide date range' : 'Show date range'" :aria-label="showDateRange ? 'Hide date range' : 'Show date range'" @click="showDateRange = !showDateRange">
<v-icon>{{ showDateRange ? 'mdi-calendar-check' : 'mdi-calendar' }}</v-icon>
</v-btn>

<v-btn
v-if="!signInRequired && isUsageAdmin"
icon
title="Admin panel"
aria-label="Open admin panel"
@click="showAdminPanel = true"
>
<v-icon>mdi-shield-crown</v-icon>
</v-btn>

<v-btn icon :title="isDark ? 'Switch to light mode' : 'Switch to dark mode'" @click="toggleTheme">
<v-btn icon :title="isDark ? 'Switch to light mode' : 'Switch to dark mode'" :aria-label="isDark ? 'Switch to light mode' : 'Switch to dark mode'" @click="toggleTheme">
<v-icon>{{ isDark ? 'mdi-weather-sunny' : 'mdi-weather-night' }}</v-icon>
</v-btn>

Expand All @@ -41,7 +42,7 @@
</AuthState>

<!-- PAT-mode info button: visible when auth is not required -->
<v-btn v-if="!isAuthRequired" icon title="Authentication info" @click="showAuthInfoDialog = true">
<v-btn v-if="!isAuthRequired" icon title="Authentication info" aria-label="Open authentication information" @click="showAuthInfoDialog = true">
<v-icon>mdi-shield-account</v-icon>
</v-btn>

Expand Down
6 changes: 3 additions & 3 deletions app/components/MetricsViewer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,9 +184,9 @@
<!-- Chart layout toggle -->
<div class="d-flex justify-end mb-2">
<v-btn-toggle v-model="chartColumns" density="compact" variant="outlined" mandatory>
<v-btn value="1" size="small" title="Single column"><v-icon size="18">mdi-view-agenda</v-icon></v-btn>
<v-btn value="2" size="small" title="Two columns"><v-icon size="18">mdi-view-grid</v-icon></v-btn>
<v-btn value="full" size="small" title="Full width"><v-icon size="18">mdi-fullscreen</v-icon></v-btn>
<v-btn value="1" size="small" title="Single column" aria-label="Single column layout"><v-icon size="18">mdi-view-agenda</v-icon></v-btn>
<v-btn value="2" size="small" title="Two columns" aria-label="Two column layout"><v-icon size="18">mdi-view-grid</v-icon></v-btn>
<v-btn value="full" size="small" title="Full width" aria-label="Full width layout"><v-icon size="18">mdi-fullscreen</v-icon></v-btn>
</v-btn-toggle>
</div>

Expand Down
6 changes: 3 additions & 3 deletions app/components/MyUsageViewer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@
<!-- Chart layout toggle -->
<div class="d-flex justify-end pa-3 pb-0">
<v-btn-toggle v-model="chartColumns" density="compact" variant="outlined" mandatory>
<v-btn value="1" size="small" title="Single column"><v-icon size="18">mdi-view-agenda</v-icon></v-btn>
<v-btn value="2" size="small" title="Two columns"><v-icon size="18">mdi-view-grid</v-icon></v-btn>
<v-btn value="full" size="small" title="Full width"><v-icon size="18">mdi-fullscreen</v-icon></v-btn>
<v-btn value="1" size="small" title="Single column" aria-label="Single column layout"><v-icon size="18">mdi-view-agenda</v-icon></v-btn>
<v-btn value="2" size="small" title="Two columns" aria-label="Two column layout"><v-icon size="18">mdi-view-grid</v-icon></v-btn>
<v-btn value="full" size="small" title="Full width" aria-label="Full width layout"><v-icon size="18">mdi-fullscreen</v-icon></v-btn>
</v-btn-toggle>
</div>

Expand Down
6 changes: 3 additions & 3 deletions app/components/PullRequestViewer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,9 @@
<v-container :fluid="chartColumns === 'full'" :class="['elevation-2', chartColumns === 'full' ? 'px-0' : 'px-4']">
<div class="d-flex justify-end mb-2">
<v-btn-toggle v-model="chartColumns" density="compact" variant="outlined" mandatory>
<v-btn value="1" size="small" title="Single column"><v-icon size="18">mdi-view-agenda</v-icon></v-btn>
<v-btn value="2" size="small" title="Two columns"><v-icon size="18">mdi-view-grid</v-icon></v-btn>
<v-btn value="full" size="small" title="Full width"><v-icon size="18">mdi-fullscreen</v-icon></v-btn>
<v-btn value="1" size="small" title="Single column" aria-label="Single column layout"><v-icon size="18">mdi-view-agenda</v-icon></v-btn>
<v-btn value="2" size="small" title="Two columns" aria-label="Two column layout"><v-icon size="18">mdi-view-grid</v-icon></v-btn>
<v-btn value="full" size="small" title="Full width" aria-label="Full width layout"><v-icon size="18">mdi-fullscreen</v-icon></v-btn>
</v-btn-toggle>
</div>
<v-row>
Expand Down
6 changes: 3 additions & 3 deletions app/components/SeatsAnalysisViewer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,9 @@
<v-container :fluid="chartColumns === 'full'" :class="['elevation-2', chartColumns === 'full' ? 'px-0' : 'px-4']">
<div class="d-flex justify-end mb-2">
<v-btn-toggle v-model="chartColumns" density="compact" variant="outlined" mandatory>
<v-btn value="1" size="small" title="Single column"><v-icon size="18">mdi-view-agenda</v-icon></v-btn>
<v-btn value="2" size="small" title="Two columns"><v-icon size="18">mdi-view-grid</v-icon></v-btn>
<v-btn value="full" size="small" title="Full width"><v-icon size="18">mdi-fullscreen</v-icon></v-btn>
<v-btn value="1" size="small" title="Single column" aria-label="Single column layout"><v-icon size="18">mdi-view-agenda</v-icon></v-btn>
<v-btn value="2" size="small" title="Two columns" aria-label="Two column layout"><v-icon size="18">mdi-view-grid</v-icon></v-btn>
<v-btn value="full" size="small" title="Full width" aria-label="Full width layout"><v-icon size="18">mdi-fullscreen</v-icon></v-btn>
</v-btn-toggle>
</div>
<v-row v-if="seatsHistory.length > 0" class="mb-4">
Expand Down
16 changes: 10 additions & 6 deletions app/components/TeamsComponent.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@
v-bind="tooltipProps"
:to="`/orgs/${selectedOrg}`"
icon="mdi-open-in-new"
aria-label="Switch to organization view"
variant="text"
size="small"
density="compact"
Expand Down Expand Up @@ -138,6 +139,7 @@
size="x-small"
icon
title="Deselect team"
aria-label="Deselect team"
@click="selectedTeams = []"
>
<v-icon size="14">mdi-close</v-icon>
Expand Down Expand Up @@ -184,6 +186,7 @@
size="x-small"
icon
title="Clear filter"
aria-label="Clear reporting hierarchy filter"
@click="onEntraSelect([], '', undefined)"
>
<v-icon size="14">mdi-close</v-icon>
Expand Down Expand Up @@ -235,9 +238,9 @@
<v-container :fluid="chartColumns === 'full'" :class="['elevation-2 mt-1 mb-2', chartColumns === 'full' ? 'px-0' : 'px-4']">
<div class="d-flex justify-end mb-3">
<v-btn-toggle v-model="chartColumns" density="compact" variant="outlined" mandatory>
<v-btn value="1" size="small" title="Single column"><v-icon size="18">mdi-view-agenda</v-icon></v-btn>
<v-btn value="2" size="small" title="Two columns"><v-icon size="18">mdi-view-grid</v-icon></v-btn>
<v-btn value="full" size="small" title="Full width"><v-icon size="18">mdi-fullscreen</v-icon></v-btn>
<v-btn value="1" size="small" title="Single column" aria-label="Single column layout"><v-icon size="18">mdi-view-agenda</v-icon></v-btn>
<v-btn value="2" size="small" title="Two columns" aria-label="Two column layout"><v-icon size="18">mdi-view-grid</v-icon></v-btn>
<v-btn value="full" size="small" title="Full width" aria-label="Full width layout"><v-icon size="18">mdi-fullscreen</v-icon></v-btn>
</v-btn-toggle>
</div>

Expand Down Expand Up @@ -422,6 +425,7 @@
size="x-small"
icon
:title="`Remove ${card.teamName}`"
:aria-label="`Remove ${card.teamName}`"
@click="selectedTeams = selectedTeams.filter(s => s !== card.slug)"
>
<v-icon size="14">mdi-close</v-icon>
Expand All @@ -448,9 +452,9 @@
<v-container :fluid="chartColumns === 'full'" :class="['elevation-2 mt-1 mb-2', chartColumns === 'full' ? 'px-0' : 'px-4']">
<div class="d-flex justify-end mb-3">
<v-btn-toggle v-model="chartColumns" density="compact" variant="outlined" mandatory>
<v-btn value="1" size="small" title="Single column"><v-icon size="18">mdi-view-agenda</v-icon></v-btn>
<v-btn value="2" size="small" title="Two columns"><v-icon size="18">mdi-view-grid</v-icon></v-btn>
<v-btn value="full" size="small" title="Full width"><v-icon size="18">mdi-fullscreen</v-icon></v-btn>
<v-btn value="1" size="small" title="Single column" aria-label="Single column layout"><v-icon size="18">mdi-view-agenda</v-icon></v-btn>
<v-btn value="2" size="small" title="Two columns" aria-label="Two column layout"><v-icon size="18">mdi-view-grid</v-icon></v-btn>
<v-btn value="full" size="small" title="Full width" aria-label="Full width layout"><v-icon size="18">mdi-fullscreen</v-icon></v-btn>
</v-btn-toggle>
</div>

Expand Down
Loading
Loading