Java: revert filtering of ancillary data extraction #21117
Merged
+0
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
approved these changes
Jan 7, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts a previous feature that filtered ancillary data extraction for Java code scanning based on paths and paths-ignore settings. The revert is necessary because the filtering breaks code-scanning configurations that use path-traversal sequences (. and ..) in traced mode.
Key Changes
- Removes the change-notes documentation for the now-reverted feature
- Deletes the integration test suite that validated the path filtering behavior
- Removes all associated test data files (Java, XML, and configuration files)
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| java/ql/lib/change-notes/2025-12-16-java-xml-paths.md | Removes the change note documenting the now-reverted path filtering feature |
| java/ql/integration-tests/java/buildless-paths/test.ql | Deletes the test query that validated XML and Java file filtering |
| java/ql/integration-tests/java/buildless-paths/test.py | Removes the test driver for the buildless paths integration test |
| java/ql/integration-tests/java/buildless-paths/test.expected | Deletes the expected test results |
| java/ql/integration-tests/java/buildless-paths/codescanning-config.yml | Removes the code scanning configuration used for testing path filtering |
| java/ql/integration-tests/java/buildless-paths/sibling/ShouldNotAppear1.xml | Deletes test data for files that should be filtered out |
| java/ql/integration-tests/java/buildless-paths/sibling/ShouldNotAppear1.java | Deletes test data for files that should be filtered out |
| java/ql/integration-tests/java/buildless-paths/include/exclude/ShouldNotAppear3.xml | Removes test data for excluded XML files |
| java/ql/integration-tests/java/buildless-paths/include/exclude/ShouldNotAppear3.java | Removes test data for excluded Java files |
| java/ql/integration-tests/java/buildless-paths/include/ShouldAppear2.xml | Deletes test data for XML files that should be included |
| java/ql/integration-tests/java/buildless-paths/include/ShouldAppear2.java | Deletes test data for Java files that should be included |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because doing so presently breaks a code-scanning config that uses path-traversal sequences (. and ..) in its paths or paths-ignore directives, and the Java configuration is in traced mode (buildless would already have objected to these, since it uses resolve files which also doesn't tolerate them).