Repository navigation
Require evidence before reporting red-team security findings - #67542
Merged
pelikhan merged 2 commits intoOct 11, 2026
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix security issues from red team findings
Require evidence before reporting red-team security findings
Oct 11, 2026
pelikhan
marked this pull request as ready for review
October 11, 2026 00:57
pelikhan
deleted the
copilot/security-2026-10-10-fix-red-team-findings
branch
October 11, 2026 00:57
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Candidate promotion and dismissed-candidate reporting can still produce inaccurate results.
1 open finding
What changed in this PR
Adds an evidence gate so heuristic security matches are validated before reporting.
Changes:
- Reclassifies secret-exfiltration and entropy matches as candidates.
- Requires source-to-sink verification and records dismissals.
- Labels issue summaries as validated findings.
Security review found two reporting-path gaps; scanners were not executed in this review environment.
| File | Description |
|---|---|
.github/workflows/daily-security-red-team.md |
Adds candidate validation and reporting rules. |
.github/workflows/daily-security-red-team.lock.yml |
Updates generated workflow hashes. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
| 1. Verify that each cited path exists and that its line number is in range and points to the behavior being reported. Do not treat imports, comments, type declarations, or test fixtures alone as evidence of a production vulnerability. | ||
| 2. Treat regex matches, suspicious keywords, entropy scores, and long encoded strings as leads only. A heuristic match does not establish malicious behavior. | ||
| 3. For any `SECRET_EXFIL_CANDIDATE`, identify the sensitive value source and the outbound network sink, then trace the same value from source to sink. Cite the exact source and sink lines and explain the data flow. An environment-variable read, a network call, or high entropy on its own is insufficient. Promote the candidate to `SECRET_EXFIL` only when this path is verified; otherwise remove it from `FINDINGS[]` and record the reason in `$CACHE_DIR/dismissed-findings-${TIMESTAMP}.json`. | ||
| 4. Apply the same evidence standard to other finding types: retain only findings supported by the cited code and its behavior. If a candidate cannot be verified, do not report it as a confirmed issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The daily scan reported 14
SECRET_EXFILfindings without demonstrating secret-to-network data flow; cited lines included imports and test scaffolding. Heuristic matches could be treated as confirmed findings without consistent validation across scan variants.SECRET_EXFILrequires tracing the same sensitive value from source to outbound sink. Unverified candidates are discarded.