Repository navigation
Use a single page-level heading on the homepage - #74795
Conversation
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
|
✅ Test Quality Sentinel completed test quality analysis. Test Quality SentinelOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
There was a problem hiding this comment.
🟡 Changes recommended
An active nit remains because the accessibility test checks only an aggregate h2 count rather than enforcing exactly one h2 within each variant.
1 open issue
What changed in this PR
Updates the homepage heading hierarchy so the page title remains the sole <h1>, while all three alternate hero variants use styled <h2> headings.
Changes:
- Converts Hero A, C, and D headlines from
<h1>to<h2>. - Preserves the existing visual styling for both heading levels.
- Adds accessibility regression coverage for the homepage heading hierarchy.
| File | Description |
|---|---|
docs/tests/homepage-accessibility.spec.ts |
Adds heading hierarchy regression coverage and retains existing accessibility checks. |
docs/src/components/landing/LandingHero.astro |
Applies shared hero heading styling to both <h1> and <h2>. |
docs/src/components/landing/HeroVD.astro |
Changes the Continuous AI hero headline to <h2>. |
docs/src/components/landing/HeroVC.astro |
Changes the coding-agents hero headline to <h2>. |
docs/src/components/landing/HeroVA.astro |
Changes the AI-powered workflows hero headline to <h2>. |
This pull request is ready to be approved.
Review effort: Lite (auto)
|
|
||
| await expect(page.getByRole("heading", { level: 1 })).toHaveCount(1); | ||
| await expect(page.locator("#hero [data-variant] h1")).toHaveCount(0); | ||
| await expect(page.locator("#hero [data-variant] h2")).toHaveCount(3); |
|
🎉 This pull request is included in a new release. Release: |
The homepage exposed multiple visible
<h1>elements, making its heading hierarchy ambiguous. Keep the page title as the sole<h1>and use<h2>for the alternate hero headlines.<h2>and preserve their existing visual styling.<h1>and<h2>headings for every hero variant; existing responsive navigation coverage remains unchanged.