Repository navigation
[dead-code] chore: remove dead functions — 1 function removed - #74871
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
An active documentation inconsistency remains because the ADR still describes a helper that has been removed from the repository.
1 open issue
What changed in this PR
Removes the unused buildSafeOutputItemsManifestUploadStep helper and updates tests to call buildSafeOutputManifestUploadStep with includeItems=true, preserving existing behavior and coverage.
Changes:
- Deletes the redundant safe-output upload wrapper.
- Updates safe-output and redaction-gating tests to use the generalized helper.
- Review note: the ADR still references the removed helper and should be updated.
| File | Summary |
|---|---|
pkg/workflow/redaction_upload_gating_test.go |
Updates redaction-gating coverage to use the generalized upload-step builder. |
pkg/workflow/compiler_safe_outputs_steps.go |
Removes the dead wrapper function. |
pkg/workflow/compiler_safe_outputs_job_test.go |
Migrates manifest upload tests to the generalized helper. |
Review effort: Lite (auto)
| return buildSafeOutputManifestUploadStep(prefix, pinAction, claimArtifacts, data, true) | ||
| } | ||
|
|
||
| func buildSafeOutputManifestUploadStep(prefix string, pinAction func(string) string, claimArtifacts bool, data *WorkflowData, includeItems bool) []string { |
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅
|
|
✅ Ponytail Reviewer completed successfully!
|
|
✅ PR Code Quality Reviewer completed the code quality review.
|
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft. Design Decision Gate 🏗️Outcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ Test Quality Sentinel completed test quality analysis. Test Quality SentinelOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
🎉 This pull request is included in a new release. Release: |
Functions Removed
buildSafeOutputItemsManifestUploadSteppkg/workflow/compiler_safe_outputs_steps.goIts tests now call the underlying
buildSafeOutputManifestUploadStep(..., true)instead, so no tests were deleted.Tests Removed
None
Verification
go build ./...go vet ./...go vet -tags=integration ./pkg/workflowmake fmtOther deadcode candidates were skipped: they are used by non-test code (the WASM
ParseWorkflowStringpath), or they have many test-only callers that I did not delete in this batch.https://github.com/github/gh-aw/actions/runs/41845664561