Repository navigation
Clarify sprintfbool analyzer function names - #74882
Conversation
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
|
✅ PR Code Quality Reviewer completed the code quality review.
|
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft. Design Decision Gate 🏗️Outcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ Test Quality Sentinel completed test quality analysis. Test Quality SentinelOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ Ponytail Reviewer completed successfully! Ponytail ReviewerOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅
|
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported, and the change is limited to coordinated internal renames with updated references and documentation.
No open issues 🎉
What changed in this PR
This pull request clarifies internal sprintfbool analyzer function names, improving discoverability while preserving behavior.
Changes:
- Renamed the analyzer callback to
analyzeSprintfBool. - Renamed the orphaned
fmtimport status helper tocomputeOrphanedFmtImportStatus. - Renamed the import-edit helper to
buildStrconvFmtImportEdits. - Updated registrations, call sites, and helper comments.
| File | Description |
|---|---|
pkg/linters/sprintfbool/sprintfbool.go |
Renames the analyzer callback and import-related helpers while updating all references and documentation. |
Review effort: Lite (auto)
|
🎉 This pull request is included in a new release. Release: |
The
sprintfboolanalyzer had generic helper names that obscured their roles. Rename the analyzer callback and import helpers to make their purpose explicit.run→analyzeSprintfBool,computeOrphanFmtStatus→computeOrphanedFmtImportStatus, andbuildImportEdits→buildStrconvFmtImportEdits.