Skip to content

Clarify sprintfbool analyzer function names - #74882

Merged
pelikhan merged 2 commits into
mainfrom
copilot/function-namer-go-rename-sprintfbool
Nov 4, 2026
Merged

pelikhan merged 2 commits into
mainfrom
copilot/function-namer-go-rename-sprintfbool

Conversation

Copilot AI commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

The sprintfbool analyzer had generic helper names that obscured their roles. Rename the analyzer callback and import helpers to make their purpose explicit.

  • Renames: run → analyzeSprintfBool, computeOrphanFmtStatus → computeOrphanedFmtImportStatus, and buildImportEdits → buildStrconvFmtImportEdits.
  • References: Update the analyzer registration, call sites, and helper comments.
var Analyzer = analyzerutil.New(..., analyzeSprintfBool)

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Copilot AI changed the title [WIP] Rename functions in pkg/linters/sprintfbool for clarity Clarify sprintfbool analyzer function names Nov 4, 2026
Copilot AI requested a review from gh-aw-bot November 4, 2026 15:30
@pelikhan
pelikhan marked this pull request as ready for review November 4, 2026 15:31
Copilot AI auto review requested due to automatic review settings November 4, 2026 15:31
@pelikhan
pelikhan merged commit 4b2ab1a into main Nov 4, 2026
27 of 37 checks passed
@pelikhan
pelikhan deleted the copilot/function-namer-go-rename-sprintfbool branch November 4, 2026 15:31
Copilot stopped reviewing on behalf of pelikhan due to an error November 4, 2026 15:31
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

✅ PR Code Quality Reviewer completed the code quality review.

🔎 Code quality review by PR Code Quality Reviewer

@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft.

Design Decision Gate 🏗️

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Design Decision Gate 🏗️ · routed: gpt56 max · ~1 AIC · ⌖ ~2 AIC · ⊞ 7.7K · ◷

🏗️ ADR gate enforced by Design Decision Gate 🏗️

@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

✅ Test Quality Sentinel completed test quality analysis.

Test Quality Sentinel

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Test Quality Sentinel · routed: gpt56 max · ~2 AIC · ⌖ ~1 AIC · ⊞ 6.3K · ◷

🧪 Test quality analysis by Test Quality Sentinel

@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

✅ Ponytail Reviewer completed successfully!

Ponytail Reviewer

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Ponytail Reviewer · routed: gpt56 max · ~1 AIC · ⌖ ~1 AIC · ⊞ 118 · ◷

Generated by Ponytail Reviewer for #74882

@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported, and the change is limited to coordinated internal renames with updated references and documentation.

No open issues 🎉

What changed in this PR

This pull request clarifies internal sprintfbool analyzer function names, improving discoverability while preserving behavior.

Changes:

  • Renamed the analyzer callback to analyzeSprintfBool.
  • Renamed the orphaned fmt import status helper to computeOrphanedFmtImportStatus.
  • Renamed the import-edit helper to buildStrconvFmtImportEdits.
  • Updated registrations, call sites, and helper comments.
File Description
pkg/​linters/​sprintfbool/​sprintfbool.go Renames the analyzer callback and import-related helpers while updating all references and documentation.

Review effort: Lite (auto)

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[function-namer] Go function rename plan: pkg/linters/sprintfbool

4 participants