Skip to content

Upgrade React to v19.2.3 (and fix type errors in useRef hooks) #4237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
d10c merged 9 commits into from
Dec 18, 2025
Merged

Upgrade React to v19.2.3 (and fix type errors in useRef hooks) #4237

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5e712e2
Initial plan
Copilot Dec 17, 2025
8ca5bfe
Merge React 19 upgrade from dependabot branch
Copilot Dec 17, 2025
40f6dab
Fix React 19 useRef type errors and eslint config
Copilot Dec 17, 2025
450e35f
Upgrade react-dom to 19.2.3 to match react version
Copilot Dec 17, 2025
ae270c8
Restore correct package versions (revert unintended downgrades from d…
Copilot Dec 17, 2025
a1a9b65
Security fix: Update glob to 11.1.0 to address command injection vuln…
Copilot Dec 17, 2025
ffac626
Upgrade React to 19.2.3 and fix useRef type errors
Copilot Dec 17, 2025
8febd66
Fix eslint config: restore .flat accessor for reactHooks.configs
Copilot Dec 17, 2025
1cae7d7
Use caret (^) prefix for React package versions
Copilot Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions extensions/ql-vscode/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ export default tseslint.config(
extends: [
react.configs.flat.recommended,
react.configs.flat['jsx-runtime'],
reactHooks.configs.flat['recommended-latest'],
reactHooks.configs['recommended-latest'],
storybook.configs['flat/recommended'],
github.getFlatConfigs().react,
],
Expand All @@ -128,7 +128,7 @@ export default tseslint.config(
extends: [
react.configs.flat.recommended,
react.configs.flat['jsx-runtime'],
reactHooks.configs.flat['recommended-latest'],
reactHooks.configs['recommended-latest'],
github.getFlatConfigs().react,
],
settings: {
Expand Down
3,435 changes: 1,537 additions & 1,898 deletions extensions/ql-vscode/package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

123 changes: 32 additions & 91 deletions extensions/ql-vscode/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,6 @@
{
"type": "object",
"title": "CLI",
"id": "codeQL.cli",
"order": 0,
"properties": {
"codeQL.cli.executablePath": {
Expand All @@ -183,7 +182,6 @@
{
"type": "object",
"title": "Running queries",
"id": "codeQL.runningQueries",
"order": 1,
"properties": {
"codeQL.runningQueries.numberOfThreads": {
Expand All @@ -197,7 +195,6 @@
"type": "boolean",
"default": false,
"scope": "window",
"deprecationMessage": "This setting no longer has any effect.",
"description": "Aggressively save intermediate results to the disk cache. This may speed up subsequent queries if they are similar. Be aware that using this option will greatly increase disk usage and initial evaluation time."
},
"codeQL.runningQueries.cacheSize": {
Expand Down Expand Up @@ -282,7 +279,6 @@
{
"type": "object",
"title": "Results",
"id": "codeQL.resultsDisplay",
"order": 2,
"properties": {
"codeQL.resultsDisplay.pageSize": {
Expand All @@ -295,7 +291,6 @@
{
"type": "object",
"title": "Query history",
"id": "codeQL.queryHistory",
"order": 3,
"properties": {
"codeQL.queryHistory.format": {
Expand All @@ -314,7 +309,6 @@
{
"type": "object",
"title": "Running tests",
"id": "codeQL.runningTests",
"order": 4,
"properties": {
"codeQL.runningTests.additionalTestArguments": {
Expand All @@ -336,7 +330,6 @@
{
"type": "object",
"title": "Variant analysis",
"id": "codeQL.variantAnalysis",
"order": 5,
"properties": {
"codeQL.variantAnalysis.controllerRepo": {
Expand Down Expand Up @@ -379,7 +372,6 @@
{
"type": "object",
"title": "Adding databases",
"id": "codeQL.addingDatabases",
"order": 6,
"properties": {
"codeQL.addingDatabases.downloadTimeout": {
Expand Down Expand Up @@ -407,7 +399,6 @@
{
"type": "object",
"title": "Creating queries",
"id": "codeQL.createQuery",
"order": 7,
"properties": {
"codeQL.createQuery.qlPackLocation": {
Expand All @@ -433,7 +424,6 @@
{
"type": "object",
"title": "GitHub Databases",
"id": "codeQL.githubDatabase",
"order": 8,
"properties": {
"codeQL.githubDatabase.download": {
Expand Down Expand Up @@ -467,7 +457,6 @@
{
"type": "object",
"title": "Model Editor",
"id": "codeQL.model",
"order": 9,
"properties": {
"codeQL.model.packLocation": {
Expand All @@ -485,7 +474,6 @@
{
"type": "object",
"title": "Log insights",
"id": "codeQL.logInsights",
"order": 10,
"properties": {
"codeQL.logInsights.joinOrderWarningThreshold": {
Expand All @@ -500,7 +488,6 @@
{
"type": "object",
"title": "Telemetry",
"id": "codeQL.telemetry",
"order": 11,
"properties": {
"codeQL.telemetry.logTelemetry": {
Expand Down Expand Up @@ -528,14 +515,6 @@
"command": "codeQL.runQueryContextEditor",
"title": "CodeQL: Run Query on Selected Database"
},
{
"command": "codeQL.runWarmOverlayBaseCacheForQuery",
"title": "CodeQL: Warm Overlay-Base Cache for Query"
},
{
"command": "codeQL.runWarmOverlayBaseCacheForQueryContextEditor",
"title": "CodeQL: Warm Overlay-Base Cache for Query"
},
{
"command": "codeQL.debugQuery",
"title": "CodeQL: Debug Query"
Expand Down Expand Up @@ -592,18 +571,10 @@
"command": "codeQL.runQueries",
"title": "CodeQL: Run Queries in Selected Files"
},
{
"command": "codeQL.runWarmOverlayBaseCacheForQueries",
"title": "CodeQL: Warm Overlay-Base Cache for Queries in Selected Files"
},
{
"command": "codeQL.runQuerySuite",
"title": "CodeQL: Run Selected Query Suite"
},
{
"command": "codeQL.runWarmOverlayBaseCacheForQuerySuite",
"title": "CodeQL: Warm Overlay-Base Cache for Query Suite"
},
{
"command": "codeQL.quickEval",
"title": "CodeQL: Quick Evaluation"
Expand Down Expand Up @@ -821,7 +792,7 @@
},
{
"command": "codeQL.trimOverlayBaseCache",
"title": "CodeQL: Trim Cache to Overlay-Base"
"title": "CodeQL: Trim Overlay Base Cache"
},
{
"command": "codeQL.installPackDependencies",
Expand Down Expand Up @@ -1407,21 +1378,11 @@
"group": "9_qlCommands",
"when": "resourceScheme != codeql-zip-archive"
},
{
"command": "codeQL.runWarmOverlayBaseCacheForQueries",
"group": "9_qlCommands",
"when": "resourceScheme != codeql-zip-archive && config.codeQL.canary"
},
{
"command": "codeQL.runQuerySuite",
"group": "9_qlCommands",
"when": "resourceScheme != codeql-zip-archive && resourceExtname == .qls && !explorerResourceIsFolder && !listMultiSelection && config.codeQL.canary"
},
{
"command": "codeQL.runWarmOverlayBaseCacheForQuerySuite",
"group": "9_qlCommands",
"when": "resourceScheme != codeql-zip-archive && resourceExtname == .qls && !explorerResourceIsFolder && !listMultiSelection && config.codeQL.canary"
},
{
"command": "codeQL.runVariantAnalysisContextExplorer",
"group": "9_qlCommands",
Expand All @@ -1447,10 +1408,6 @@
"command": "codeQL.runQuery",
"when": "resourceLangId == ql && resourceExtname == .ql"
},
{
"command": "codeQL.runWarmOverlayBaseCacheForQuery",
"when": "resourceLangId == ql && resourceExtname == .ql && config.codeQL.canary"
},
{
"command": "codeQLQueries.runLocalQueryFromQueriesPanel",
"when": "false"
Expand All @@ -1471,10 +1428,6 @@
"command": "codeQL.runQueryContextEditor",
"when": "false"
},
{
"command": "codeQL.runWarmOverlayBaseCacheForQueryContextEditor",
"when": "false"
},
{
"command": "codeQL.debugQuery",
"when": "config.codeQL.canary && editorLangId == ql && resourceExtname == .ql && !inDebugMode"
Expand Down Expand Up @@ -1527,18 +1480,10 @@
"command": "codeQL.runQueries",
"when": "false"
},
{
"command": "codeQL.runWarmOverlayBaseCacheForQueries",
"when": "false"
},
{
"command": "codeQL.runQuerySuite",
"when": "false"
},
{
"command": "codeQL.runWarmOverlayBaseCacheForQuerySuite",
"when": "false"
},
{
"command": "codeQL.quickEval",
"when": "editorLangId == ql"
Expand Down Expand Up @@ -1887,10 +1832,6 @@
"command": "codeQL.runQueryContextEditor",
"when": "editorLangId == ql && resourceExtname == .ql && !inDebugMode"
},
{
"command": "codeQL.runWarmOverlayBaseCacheForQueryContextEditor",
"when": "editorLangId == ql && resourceExtname == .ql && !inDebugMode && config.codeQL.canary"
},
{
"command": "codeQL.runQueryOnMultipleDatabasesContextEditor",
"when": "editorLangId == ql && resourceExtname == .ql"
Expand Down Expand Up @@ -2035,13 +1976,13 @@
"build": "gulp",
"watch": "gulp watch",
"test": "npm-run-all test:*",
"test:unit": "cross-env TZ=UTC LANG=en-US NODE_OPTIONS=--no-experimental-strip-types jest --projects test/unit-tests",
"test:view": "cross-env NODE_OPTIONS=--no-experimental-strip-types jest --projects src/view",
"test:unit": "cross-env TZ=UTC LANG=en-US jest --projects test/unit-tests",
"test:view": "jest --projects src/view",
"test:vscode-integration": "npm-run-all test:vscode-integration:*",
"test:vscode-integration:activated-extension": "cross-env NODE_OPTIONS=--no-experimental-strip-types jest --projects test/vscode-tests/activated-extension",
"test:vscode-integration:no-workspace": "cross-env NODE_OPTIONS=--no-experimental-strip-types jest --projects test/vscode-tests/no-workspace",
"test:vscode-integration:minimal-workspace": "cross-env NODE_OPTIONS=--no-experimental-strip-types jest --projects test/vscode-tests/minimal-workspace",
"test:cli-integration": "cross-env NODE_OPTIONS=--no-experimental-strip-types jest --projects test/vscode-tests/cli-integration --verbose",
"test:vscode-integration:activated-extension": "jest --projects test/vscode-tests/activated-extension",
"test:vscode-integration:no-workspace": "jest --projects test/vscode-tests/no-workspace",
"test:vscode-integration:minimal-workspace": "jest --projects test/vscode-tests/minimal-workspace",
"test:cli-integration": "jest --projects test/vscode-tests/cli-integration --verbose",
"clean-test-dir": "find . -type d -name .vscode-test -exec rm -r {} +",
"update-vscode": "node ./node_modules/vscode/bin/install",
"format": "prettier --write **/*.{ts,tsx} && eslint . --fix",
Expand All @@ -2064,24 +2005,24 @@
"@floating-ui/react": "^0.27.0",
"@octokit/plugin-retry": "^7.2.0",
"@octokit/plugin-throttling": "^9.6.0",
"@octokit/rest": "^22.0.1",
"@octokit/rest": "^22.0.0",
"@vscode-elements/react-elements": "^0.9.0",
"@vscode/codicons": "^0.0.43",
"@vscode/codicons": "^0.0.36",
"@vscode/debugadapter": "^1.59.0",
"@vscode/debugprotocol": "^1.68.0",
"ajv": "^8.11.0",
"chokidar": "^3.6.0",
"d3": "^7.9.0",
"d3-graphviz": "^5.0.2",
"fs-extra": "^11.1.1",
"js-yaml": "^4.1.1",
"js-yaml": "^4.1.0",
"koffi": "^2.12.0",
"msw": "^2.11.6",
"msw": "^2.7.4",
"nanoid": "^5.0.7",
"p-queue": "^8.0.1",
"proper-lockfile": "^4.1.2",
"react": "^18.3.1",
"react-dom": "^18.3.1",
"react": "19.2.3",
"react-dom": "19.2.3",
"semver": "^7.6.2",
"source-map": "^0.7.6",
"source-map-support": "^0.5.21",
Expand All @@ -2101,12 +2042,12 @@
"@babel/plugin-transform-modules-commonjs": "^7.26.3",
"@babel/preset-env": "^7.24.4",
"@babel/preset-react": "^7.27.1",
"@babel/preset-typescript": "^7.28.5",
"@eslint/js": "^9.37.0",
"@babel/preset-typescript": "^7.26.0",
"@eslint/js": "^9.28.0",
"@faker-js/faker": "^9.0.3",
"@github/markdownlint-github": "^0.8.0",
"@jest/environment": "^30.2.0",
"@jest/environment-jsdom-abstract": "^30.2.0",
"@jest/environment": "^30.0.0-alpha.7",
"@jest/environment-jsdom-abstract": "^30.0.0-alpha.7",
"@microsoft/eslint-formatter-sarif": "^3.1.0",
"@playwright/test": "^1.50.1",
"@storybook/addon-a11y": "^8.6.14",
Expand All @@ -2123,7 +2064,7 @@
"@storybook/react-vite": "^8.6.14",
"@storybook/theming": "^8.6.14",
"@testing-library/dom": "^10.4.1",
"@testing-library/jest-dom": "^6.9.1",
"@testing-library/jest-dom": "^6.8.0",
"@testing-library/react": "^16.3.0",
"@testing-library/user-event": "^14.6.1",
"@types/cross-spawn": "^6.0.6",
Expand All @@ -2135,8 +2076,8 @@
"@types/js-yaml": "^4.0.6",
"@types/node": "22.19.*",
"@types/proper-lockfile": "^4.1.4",
"@types/react": "^18.3.12",
"@types/react-dom": "^18.3.1",
"@types/react": "^19.1.13",
"@types/react-dom": "^19.1.13",
"@types/sarif": "^2.1.2",
"@types/semver": "^7.5.8",
"@types/stream-json": "^1.7.1",
Expand All @@ -2153,7 +2094,7 @@
"ansi-colors": "^4.1.1",
"applicationinsights": "^2.9.5",
"cosmiconfig": "^9.0.0",
"cross-env": "^10.1.0",
"cross-env": "^7.0.3",
"cross-spawn": "^7.0.6",
"del": "^6.0.0",
"eslint": "^9.28.0",
Expand All @@ -2164,34 +2105,34 @@
"eslint-plugin-jest-dom": "^5.5.0",
"eslint-plugin-prettier": "^5.2.6",
"eslint-plugin-react": "^7.37.5",
"eslint-plugin-react-hooks": "^7.0.1",
"eslint-plugin-storybook": "^10.0.7",
"eslint-plugin-react-hooks": "^5.2.0",
"eslint-plugin-storybook": "^9.0.12",
"glob": "^11.1.0",
"gulp": "^5.0.0",
"gulp-esbuild": "^0.14.1",
"gulp-esbuild": "^0.14.0",
"gulp-replace": "^1.1.3",
"gulp-typescript": "^5.0.1",
"husky": "^9.1.7",
"jest": "^30.2.0",
"jest": "^30.0.0-alpha.7",
"jest-runner-vscode": "^3.0.1",
"jsdom": "^27.0.1",
"jsdom": "^26.1.0",
"lint-staged": "^15.3.0",
"markdownlint-cli2": "^0.17.0",
"markdownlint-cli2-formatter-pretty": "^0.0.9",
"markdownlint-cli2-formatter-pretty": "^0.0.7",
"npm-run-all": "^4.1.5",
"patch-package": "^8.0.1",
"patch-package": "^8.0.0",
"prettier": "^3.6.1",
"storybook": "^8.6.14",
"tar-stream": "^3.1.7",
"through2": "^4.0.2",
"ts-jest": "^29.3.2",
"ts-json-schema-generator": "^2.3.0",
"ts-node": "^10.9.2",
"ts-unused-exports": "^11.0.1",
"typescript": "^5.9.3",
"typescript-plugin-css-modules": "^5.2.0",
"ts-unused-exports": "^10.1.0",
"typescript": "^5.6.2",
"typescript-plugin-css-modules": "^5.1.0",
"vite": "^7.1.5",
"vite-node": "^3.2.4"
"vite-node": "^3.0.7"
},
"lint-staged": {
"./**/*.{json,css,scss}": [
Expand Down
2 changes: 1 addition & 1 deletion extensions/ql-vscode/src/view/model-alerts/ModelAlertsResults.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ export const ModelAlertsResults = ({
[modelAlerts.model],
);

const ref = useRef<HTMLElement>();
const ref = useRef<HTMLElement | undefined>(undefined);

useEffect(() => {
if (
Expand Down
2 changes: 1 addition & 1 deletion extensions/ql-vscode/src/view/model-editor/MethodRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export type MethodRowProps = {
export const MethodRow = (props: MethodRowProps) => {
const { method, methodCanBeModeled, revealedMethodSignature } = props;

const ref = useRef<HTMLElement>();
const ref = useRef<HTMLElement | undefined>(undefined);

useEffect(() => {
if (method.signature === revealedMethodSignature) {
Expand Down
Loading