Skip to content

fix: (part) suppress false warnings "Context access might be invalid" for secrets/vars #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidruzicka wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: (part) suppress false warnings "Context access might be invalid" for secrets/vars #534

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b0051b9
fix: add secrets validation configuration to GitHub Actions extension
davidruzicka Dec 3, 2025
abfaf75
fix: update warning description for repository context in configuration
davidruzicka Dec 3, 2025
205854f
fix: restart language server on secrets configuration change
davidruzicka Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,18 @@
"markdownDescription": "If this is set to true, use the auth provider for the GitHub Enterprise URL configured in `github-enterprise.uri`",
"default": false,
"scope": "window"
},
"github-actions.validation.secrets": {
"type": "string",
"enum": ["auto", "always", "never"],
"enumDescriptions": [
"Suppresses warnings when repository context is unavailable (e.g., timing issues during initialization) (recommended)",
"Always show warnings",
"Never validate secrets/variables access"
],
"default": "auto",
"description": "Controls validation of secrets and variables context access in workflow files",
"scope": "window"
}
}
},
Expand Down
9 changes: 7 additions & 2 deletions src/workflow/languageServer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import * as path from "path";
import * as vscode from "vscode";

import {Commands} from "@actions/languageserver/commands";
import {InitializationOptions, LogLevel} from "@actions/languageserver/initializationOptions";
import {InitializationOptions, LogLevel, SecretsValidationMode} from "@actions/languageserver/initializationOptions";
import {ReadFileRequest, Requests} from "@actions/languageserver/request";
import {BaseLanguageClient, LanguageClientOptions} from "vscode-languageclient";
import {LanguageClient as BrowserLanguageClient} from "vscode-languageclient/browser";
Expand All @@ -20,6 +20,10 @@ function isNode(): boolean {
return typeof process !== "undefined" && process.versions?.node != null;
}

function getSecretsValidationMode(): SecretsValidationMode {
return vscode.workspace.getConfiguration("github-actions").get<SecretsValidationMode>("validation.secrets", "auto");
}

export async function initLanguageServer(context: vscode.ExtensionContext) {
const session = await getSession();

Expand All @@ -35,7 +39,8 @@ export async function initLanguageServer(context: vscode.ExtensionContext) {
workspaceUri: repo.workspaceUri.toString(),
organizationOwned: repo.organizationOwned
})),
logLevel: PRODUCTION ? LogLevel.Warn : LogLevel.Debug
logLevel: PRODUCTION ? LogLevel.Warn : LogLevel.Debug,
secretsValidation: getSecretsValidationMode()
};

const clientOptions: LanguageClientOptions = {
Expand Down